1066482 - [Contacts] [Regression] Cannot add a new contact with only date (birthday or anniversary)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR:

Try to add a new contact that only has a date as non-empty field. 

Actual:

The done button remains disabled

Expected:

The done button is enabled and the contact can be added

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hum,

I think we removed that on purpose during the form redesign. I though it was an error, creating a contact just with a date ... cannot see the use case.

But if product wants it, let's reenable it.

Comment 2

[Jose Manuel Cantera]

Attachment: 23996.html

Comment 3

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #1)
> Hum,
> 
> I think we removed that on purpose during the form redesign. I though it was
> an error, creating a contact just with a date ... cannot see the use case.
> 
> But if product wants it, let's reenable it.

Yes, by design it can be added a contact that only has one field filled, including bday

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8488512 [details]
23996.html

Excellent and super clean solution.

Good to see you back!

Comment 5

[Jose Manuel Cantera]

landed on master:

https://github.com/mozilla-b2g/gaia/commit/c1422c2e16c3862624b9644a50dfac5fd42cda1c

Comment 6

[Loli (:lolimartinezcr)]

Tested and working
2.2
Flame
Gecko-713c41b
Gaia-32d82d2