10665 - spell checker oddities

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[buster]

from bijal:

Spell check does not start at the beginning, but at the last place you stopped
the spell checker.  This is different from 4.x behavior.
When I just spell checked the current default document that opens in Seamonkey,
the spell checker actually highlighted this whole sentence, "This  sentence  has
two  & nbsp;  tags  between  each  word".  This did not make sense because I
expected the word "nbsp" to be highlighted and not the whole sentence.

Comment 1

[kinmoz]

Accepting bug, marking M11 Milestone.

Spellchecking from the beginning of the document is easy to change. All we need
to do is pass a TRUE flag from Charlie's spellchecker init code.

Looks like I'll have to map the   character to a space in the spellchecker.

Comment 2

[kinmoz]

Moving some SpellChecker/TextServices feature requests and bugs, that can wait
till after beta 1, to milestone M14.

Comment 3

[kinmoz]

I checked in a fix for the nbsp problem:

    ns/modules/spellchk/glue/nsSpellcheckGlue.cpp  revision 1.18

r=[e-mail]

The spellchecker starts spellchecking at the text block that contains the caret
and goes until it hits the end of the document. We need to modify the front end
to prompt the user if he wants to restart spellchecking from the beginning of
the document. This has been filed as bug #23682.

Comment 4

[sujay]

waiting for 25941 to get fixed, then I'll verify this one.

Comment 5

[sujay]

verified in 2/1 build.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6ce2f194be8
[fenix] For 10665 - Show the most recent tabs at the top of the tab tray (https://github.com/mozilla-mobile/fenix/pull/10687)