1066557 - [System] Status bar error message: TypeError: roaming is undefined

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

I'm constantly seeing this error in logcat with my Flame with a sim roaming:

TypeError: roaming is undefined

Also the sim doesn't display the roaming indicator.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Possible culprit: bug 1056969. Alberto, could you take a look?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Francisco, do you have a file or line number in there?

Comment 3

[Alberto Pastor [:albertopq]]

It seems it doesn't happen 100% of the times, but I was able to repro it at some point.

E/GeckoConsole(  203): [JavaScript Error: "TypeError: roaming is undefined" {file: "app://system.gaiamobile.org/js/statusbar.js" line: 1375}]

Another side problem is that the notifications tray does not open when that happens.

Comment 4

[Alberto Pastor [:albertopq]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24020

Comment 5

[joshua.purcell]

A temporary way around this bug for me (in order to get access to the notification area again) was to enable USB storage and then restart with the USB cable plugged in. I don't USB storage is related to the bug, but the additional notification that it creates in the notification bar may be. After restarting and seeing the USB symbol in the notification area I can now expand the notification area for the first time in a few days.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8488905 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24020

This needs a test.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to joshua.purcell from comment #5)
> A temporary way around this bug for me (in order to get access to the
> notification area again) was to enable USB storage and then restart with the
> USB cable plugged in. I don't USB storage is related to the bug, but the
> additional notification that it creates in the notification bar may be.
> After restarting and seeing the USB symbol in the notification area I can
> now expand the notification area for the first time in a few days.

How was this bug related to notification tray? Did you mean to comment on bug 1065028 instead?

Comment 8

[joshua.purcell]

No I meant to reply here, since this bug seems to be related to a broken notification tray. gerard-majax mentioned that applying the patch available here solves his broken notification tray. The following comment in this thread mentions that the notification window functionality being affected by this bug as well: https://bugzilla.mozilla.org/show_bug.cgi?id=1066557#c3.

I didn't realize the but you linked to existed... I think these two are related to each other at the least, and possibly one is a duplicate of the other.

Comment 9

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/76ba0c3abb97258496ec2cd0a8c21a15874012e0

Comment 12

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Regression from 1056969, which has been uplifted

Comment 13

[Alberto Pastor [:albertopq]]

Comment on attachment 8488905 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24020

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1056969
[User impact] if declined: The utility tray sometimes doesn't work. Roaming icon is not shown
[Testing completed]: Added unit tests
[Risk to taking this patch] (and alternatives if risky): Given the tests added and that has been tested for a while in master without any report, I think we can consider that the risk is quite low.
[String changes made]:-

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c6aaaa626dedaa110a16b2200bb420d89f65f3bf

Comment 15

[Gregor Wagner [:gwagner]]

Roaming icon is not shown and we have to rely on utility tray.

Comment 16

[Alberto Pastor [:albertopq]]

I don't think it makes sense an integration test for this. We can discuss in a triage.