Closed Bug 1066588 Opened 5 years ago Closed 5 years ago

don't show e10s notification for Talos

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

I got a bunch of Talos regression emails after landing bug 1064885. Presumably because the notification is now interfering with the test. It shouldn't show up there.
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8488601 - Flags: review?(jmaher)
Comment on attachment 8488601 [details] [diff] [review]
patch

Review of attachment 8488601 [details] [diff] [review]:
-----------------------------------------------------------------

looks great. Do we need this on android?  If we do I need to upload a talos.zip.

next steps:
land this in the talos repo
[talos.zip if needed]
update testing/talos/talos.json (in m-c)
land talos.json changes on integration branch
Attachment #8488601 - Flags: review?(jmaher) → review+
Thanks for the quick turnaround and tips, Joel.

https://hg.mozilla.org/integration/fx-team/rev/0a03eb20fac5
Target Milestone: --- → Firefox 35
https://hg.mozilla.org/mozilla-central/rev/0a03eb20fac5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Apparently the prompt returned, and apparently it's now hanging off a new pref browser.displayedE10SPrompt.1 (the previous pref didn't have '.1').

Reprompting after the user explicitly answered "No, thank you" is rather pushy, isn't it?
Yes, it is! I love it!
Did we end up fixing this for prompt v2 in-product somehow? Is Talos still affected?
Flags: needinfo?(felipc)
A new bug was filed for it, bug 1082647
Flags: needinfo?(felipc)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.