1066588 - don't show e10s notification for Talos

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

I got a bunch of Talos regression emails after landing bug 1064885. Presumably because the notification is now interfering with the test. It shouldn't show up there.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8488601 [details] [diff] [review]
patch

Review of attachment 8488601 [details] [diff] [review]:
-----------------------------------------------------------------

looks great. Do we need this on android?  If we do I need to upload a talos.zip.

next steps:
land this in the talos repo
[talos.zip if needed]
update testing/talos/talos.json (in m-c)
land talos.json changes on integration branch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Thanks for the quick turnaround and tips, Joel.

https://hg.mozilla.org/integration/fx-team/rev/0a03eb20fac5

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a03eb20fac5

Comment 5

[Avi Halachmi (:avih)]

Apparently the prompt returned, and apparently it's now hanging off a new pref browser.displayedE10SPrompt.1 (the previous pref didn't have '.1').

Reprompting after the user explicitly answered "No, thank you" is rather pushy, isn't it?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yes, it is! I love it!

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Did we end up fixing this for prompt v2 in-product somehow? Is Talos still affected?

Comment 8

[:Felipe Gomes (needinfo for replies!)]

A new bug was filed for it, bug 1082647