10666 - Test filtering of numeric input in GFX Ender widgets

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[buster]

from bijal:

When inserting a table, I tried to change the table width by typing in 100.
However, I could not do this and the text which had 50 in it actually went to
0150 which did not make sense.  In fact, I completely deleted the 0150 by
hitting the DELETE key and then entered 100 again.  However, it displayed as
001.

Comment 1

[Charles Manske]

this is caused by the onclick="forceinteger()" handler that filters key input.
It only occures on Windows using the native editbox widget.
When we switch to using Ender as the input widget, if it works with that
we can ignore this problem, correct?

Comment 2

[buster]

yes, in the long term, we only care how well these things work with gfx widgets.
bug for M9, gfx text widgets will not be enabled.  is there any quick fix, like
not calling this code at all, to make M9 more usable?

Comment 3

[Charles Manske]

Yes, simply remove the onclick handlers. I'll put that on the list of bugs
to fix for M9.

Comment 4

[Charles Manske]

The "fix" described is checked in. Solution was a temporary fix to not do the
number filtering. Waiting for GFX Ender widget before turning back on, so
summary was changed to remind us to turn filtering back on and test it later.

Comment 5

[Charles Manske]

With GFX widgets on, the "forceInteger" filter is working better (doesn't show
previous problems) but is still not 100%.
Test case:
1. Launch editor
2. Be sure selection is not in a table.
3. Click in Insert Table toolbar button
4. Type in the "rows" editbox. You should not be able to type non-integer
characters, but you can type 1, then the filter kicks in and suppresses
any non-integers after that.
Kathy and Pete: Should I fix this or is Pete available to fix it?

Comment 6

[Kathleen :Brade]

this was working correctly on Mac at one time but it now seems to be broken.  I'm
pretty sure that Pete said he would be wrapped up with other things through the
entire month so please go ahead and fix it.  Charley--let me know if you want me
to dig up Pete's original code (it'd also be somewhere in cvs, a prior revision).
I *know* that worked on every platform at one time... (Pete checked Linux and
Windows, I checked Mac).

Comment 7

[pcollins]

kathy, i mailed charlie. the problem should be resolved using onkeyup.
because it is the only event handler that seems to catch the new data.
I use to have a comment specifying that.

hope to be back in oct

pete

Comment 8

[Charles Manske]

Filtering on "onkeyup" rather than "onkeypress" works.
The non-integer character shows up on keydown, then gets removed on keyup.
While a bit wacky, I guess that informs the user what's going on, so its a good
feature!
I'll check it in for M12.

Comment 9

[Charles Manske]

Checked in 9/30.

Comment 10

[sujay]

verified in 10/12 build.