Closed Bug 1066609 Opened 5 years ago Closed 5 years ago

Various Loop xpcshell tests will perma-fail when Gecko 35 merges to beta

Categories

(Hello (Loop) :: Client, defect)

defect
Not set

Tracking

(firefox34 verified, firefox35 verified)

VERIFIED FIXED
mozilla35
Tracking Status
firefox34 --- verified
firefox35 --- verified

People

(Reporter: RyanVM, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached file Log copypasta
Gecko 35 is currently on m-c. When it hits beta, various Loop xpcshell tests are going to perma-fail as shown by the log below. Please fix these issues at your earliest convenience :)

https://tbpl.mozilla.org/php/getParsedLog.php?id=47849778&tree=Try
Attached patch The fixSplinter Review
This fixes the tests - unfortunately xpcshell tests don't yet take prefs from a central location, so we just have to set it in the head.js file.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Attachment #8490727 - Flags: review?(adam)
Blocks: 1055319
Keywords: regression
Target Milestone: --- → mozilla35
Attachment #8490727 - Flags: review?(adam) → review+
https://hg.mozilla.org/mozilla-central/rev/80cf8eca9c81
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Comment on attachment 8490727 [details] [diff] [review]
The fix

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8490727 - Flags: approval-mozilla-aurora?
Comment on attachment 8490727 [details] [diff] [review]
The fix

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8490727 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.