If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[svg-magic] Implement CSS generator.

RESOLVED FIXED

Status

()

Firefox
General
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bwinton, Assigned: bwinton)

Tracking

unspecified
x86
All
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

3 years ago
Generate an include file for the CSS, as described below.

toolbarSprites.inc (generated):
  %define whateverButton list-style-image: url("chrome://browser/skin/toolbars.svg");-moz-image-region: rect(0, 14px, 10px, 0);
  %define whateverHover -moz-image-region: rect(0, 14px, 10px, 10px);
  %define whateverActive -moz-image-region: rect(0, 14px, 10px, 20px);

toolbar.css (non-generated/in-tree already):
  %include toolbarSprites.inc
  %filter substitution
  …
  .whateverButton {
    @whateverButton@
    margin: 0;
  }
  .whateverButton:hover {
    @whateverHover@
    margin: 0;
  }
  .whateverButton:active {
    @whateverActive@
    margin: 0;
  }

One point, because the generation is really pretty simple, and entirely specced out.
Flags: firefox-backlog+

Updated

3 years ago
Flags: qe-verify?
(Assignee)

Updated

3 years ago
Flags: qe-verify? → qe-verify-

Updated

3 years ago
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Iteration: --- → 35.2
(Assignee)

Comment 1

3 years ago
I have a preliminary version of this up, and will ping shorlander for review tomorrow.
(Assignee)

Comment 2

3 years ago
Fixed, as per https://github.com/bwinton/svg-magic/commit/6819a351a7bdc0b27fced969c8568ecfe23be3f5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.