Closed Bug 1066793 Opened 10 years ago Closed 10 years ago

Update notifications accessibility after the ambient indicator was introduced.

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access)

Attachments

(2 files)

Github pull request.
46 bytes, text/x-github-pull-request
alive
: review+
fabrice
: approval-gaia-v2.1+
Details | Review
Github pull request rebased for v2.1.
46 bytes, text/x-github-pull-request
Details | Review 
Since the ambient indicator was introduced we lost unread notifications semantics for the screen reader user. This needs to be brought back.
Attached file Github pull request. — 
This patch adds aria label for the ambient indicator. It is not to be accessed directly but instead to be used as an additional description for the status bar (if there are any unread notifications). Also fixing update toaster visibility that was in the way of the screen reader.
Attachment #8488800 - Flags: review?(alive)
Comment on attachment 8488800 [details] [review]
Github pull request.

Better having test for the aria-label adding/removing.
Attachment #8488800 - Flags: review?(alive) → review+
https://github.com/mozilla-b2g/gaia/commit/e2d70bee03b5380ac327a145e5d694fb2443f018
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8488800 [details] [review]
Github pull request.

After switching from status bar icon for notifications to the ambient indicator the notification (and count) information became inaccessible to the screen reader user. This patch makes screen reader user aware of the existing unread notifications.

[Bug caused by] (feature/regressing bug #): bug 1042713 (introduction of ambient indicator in favour of notification count)

[User impact] if declined: The screen reader user will have no idea if there are any unread notifications even though the ambient indicator is present.

[Testing completed]: Added unit and ui tests.

[Risk to taking this patch] (and alternatives if risky): Fairly safe. Some changes to visibility of notifications + DOM attributes.

[String changes made]: None
Attachment #8488800 - Flags: approval-gaia-v2.1?
Attachment #8488800 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Needs rebasing for v2.1 uplift.
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
Flags: needinfo?(yzenevich)
Keywords: branch-patch-needed
Target Milestone: --- → 2.1 S5 (26sep)
Flags: needinfo?(yzenevich)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: