Closed
Bug 1066805
Opened 10 years ago
Closed 10 years ago
Drop prescontext arg from EnsureIntrinsicSizeAndRatio()
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
3.88 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
This function: > void > nsImageFrame::EnsureIntrinsicSizeAndRatio(nsPresContext* aPresContext) ...is currently always invoked as follows: > nsPresContext *presContext = PresContext(); > EnsureIntrinsicSizeAndRatio(presContext); We should just drop its aPresContext arg and make it invoke PresContext() directly.
Assignee | ||
Comment 1•10 years ago
|
||
Actually, it doesn't even need to invoke PresContext() directly, because it doesn't use its aPresContext argument at all. So we can just drop the arg and be done with it.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8488811 -
Flags: review?(tnikkel)
Comment 3•10 years ago
|
||
Comment on attachment 8488811 [details] [diff] [review] fix r+++++
Attachment #8488811 -
Flags: review?(tnikkel) → review+
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/642ed4fdf60b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•