Closed Bug 1066805 Opened 10 years ago Closed 10 years ago

Drop prescontext arg from EnsureIntrinsicSizeAndRatio()

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

This function:
> void
> nsImageFrame::EnsureIntrinsicSizeAndRatio(nsPresContext* aPresContext)
...is currently always invoked as follows:
>   nsPresContext *presContext = PresContext();
>   EnsureIntrinsicSizeAndRatio(presContext);

We should just drop its aPresContext arg and make it invoke PresContext() directly.
Actually, it doesn't even need to invoke PresContext() directly, because it doesn't use its aPresContext argument at all.

So we can just drop the arg and be done with it.
Attached patch fixSplinter Review
Attachment #8488811 - Flags: review?(tnikkel)
Comment on attachment 8488811 [details] [diff] [review]
fix

r+++++
Attachment #8488811 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/642ed4fdf60b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: