Closed Bug 1066847 Opened 8 years ago Closed 8 years ago
Statusbar icons disappear in utility tray when light themed app is in foreground
46 bytes, text/x-github-pull-request
|Details | Review|
52 bytes, text/plain
STR: 1.) Open settings app 2.) Open Utility Tray Actual Result: Statusbar icons remain dark, and so are hard to see with utility tray open. Expected Result: Statusbar icons turn light so that they show up with the utility tray.
Alberto, you've done some statubar work recently, can you take a look here?
Sure thing, I'll take a look
Assignee: nobody → apastor
[Blocking Requested - why for this release]: Broken feature. The statusbar icons are not visible with the utility tray open on some apps
blocking-b2g: --- → 2.1?
blocking-b2g: 2.1? → 2.1+
Comment on attachment 8489314 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24045 Nice fix.
Attachment #8489314 - Flags: review?(mhenretty) → review+
Please request Gaia v2.1 approval on this patch when you get a chance.
Comment on attachment 8489314 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24045 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): - [User impact] if declined: Statusbar icons hardly visible in some apps [Testing completed]: Manual testing [Risk to taking this patch] (and alternatives if risky): Low risk. CSS only [String changes made]: -
Attachment #8489314 - Flags: approval-gaia-v2.1?(fabrice)
Attachment #8489314 - Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Issue verified as fixed on Flame 2.1 and Flame 2.2 Device: Flame 2.1 KK (319mb) (Full Flash) BuildID: 20141011000201 Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1 Gecko: d813d79d3eae Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.2 Master KK (319mb) (Full Flash) BuildID: 20141011040204 Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322 Gecko: 3f6a51950eb5 Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Statusbar icons change from dark on light to light on dark when utility tray is pulled down in light themed apps.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Comment on attachment 8508630 [details] TESTS: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25361/files Test looks good! I reverted the patch for this bug, re-ran, and it indeed fails, so its a good test.
Attachment #8508630 - Flags: review?(mhenretty) → review+
You need to log in before you can comment on or make changes to this bug.