1066847 - Statusbar icons disappear in utility tray when light themed app is in foreground

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Open settings app
2.) Open Utility Tray

Actual Result:
Statusbar icons remain dark, and so are hard to see with utility tray open.

Expected Result:
Statusbar icons turn light so that they show up with the utility tray.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, you've done some statubar work recently, can you take a look here?

Comment 2

[Alberto Pastor [:albertopq]]

Sure thing, I'll take a look

Comment 3

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Broken feature. The statusbar icons are not visible with the utility tray open on some apps

Comment 4

[Alberto Pastor [:albertopq]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24045

Comment 5

[Gregor Wagner [:gwagner]]

Broken feature.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8489314 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24045

Nice fix.

Comment 7

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/25616a8cf9ab2cc98cb5e4d5323a3537a96d14a2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this patch when you get a chance.

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8489314 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24045

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: Statusbar icons hardly visible in some apps
[Testing completed]: Manual testing
[Risk to taking this patch] (and alternatives if risky): Low risk. CSS only
[String changes made]: -

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/33914cf3eb58044919f3e0777b3e5bb3845cbe21

Comment 11

[Brogan Zumwalt [Inactive]]

Issue verified as fixed on Flame 2.1 and Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Statusbar icons change from dark on light to light on dark when utility tray is pulled down in light themed apps.

Comment 12

[Alberto Pastor [:albertopq]]

Attachment: TESTS: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25361/files

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8508630 [details]
TESTS: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25361/files

Test looks good! I reverted the patch for this bug, re-ran, and it indeed fails, so its a good test.

Comment 14

[Alberto Pastor [:albertopq]]

TESTS master: https://github.com/mozilla-b2g/gaia/commit/2db78ad430ee678800fed86853a2f00e0e946c8a

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/fc4082f9087855318448dbd6539a1895bcb0aa92