Gecko fail to build on Nemo/Mer ARMV7 hardfp scratchbox2 cross target

RESOLVED FIXED in mozilla35

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla35
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8488866 [details]
autoconf.mk

1:40.48 /opt/cross/bin/armv7hl-meego-linux-gnueabi-ld: warning: hidden symbol 'pixman_glyph_cache_create' in objdir-mer-dbg/toolkit/library/../../gfx/cairo/libpixman/src/pixman-glyph.o is referenced by DSO /srv/mer/targets/jolla/usr/lib/libcairo.so
 1:40.48 mozilla-central/media/webrtc/trunk/webrtc/common_audio/signal_processing/spl_init.c:105: error: undefined reference to 'WebRtc_GetCPUFeaturesARM'
 1:40.48 mozilla-central/media/webrtc/trunk/webrtc/common_audio/resampler/sinc_resampler.cc:142: error: undefined reference to 'WebRtc_GetCPUFeaturesARM'
 1:40.48 mozilla-central/media/webrtc/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c:536: error: undefined reference to 'WebRtc_GetCPUFeaturesARM'
 1:40.48 mozilla-central/media/webrtc/trunk/webrtc/modules/audio_processing/ns/nsx_core.c:775: error: undefined reference to 'WebRtc_GetCPUFeaturesARM'
 1:40.48 collect2: ld returned 1 exit status
 1:40.48 gmake[5]: *** [libxul.so] Error 1
(Assignee)

Comment 1

3 years ago
Created attachment 8488867 [details]
mozilla-config.h
(Assignee)

Comment 2

3 years ago
Created attachment 8491293 [details] [diff] [review]
Possible workaround

need to figure out which define I should use here for this implementation, but we should have some fallback for other than android platforms.
Attachment #8491293 - Flags: feedback?(rjesup)
Comment on attachment 8491293 [details] [diff] [review]
Possible workaround

Review of attachment 8491293 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/system_wrappers/source/cpu_features.cc
@@ +69,5 @@
>  #endif
>  
> +uint64_t WebRtc_GetCPUFeaturesARM(void) {
> +  return ANDROID_CPU_ARM_FEATURE_ARMv7 | ANDROID_CPU_ARM_FEATURE_VFPv3 | ANDROID_CPU_ARM_FEATURE_NEON;
> +}

This needs to be conditional on an ARM CPU (and in this case, armv7+neon).  See also build/gyp.mozbuild
Attachment #8491293 - Flags: feedback?(rjesup) → feedback-
(Assignee)

Comment 4

3 years ago
Created attachment 8492645 [details] [diff] [review]
WebRtc_GetCPUFeaturesARM generic define
Attachment #8491293 - Attachment is obsolete: true
Attachment #8492645 - Flags: review?(rjesup)

Updated

3 years ago
Attachment #8492645 - Flags: review?(rjesup) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8495397 [details] [diff] [review]
WebRtc_GetCPUFeaturesARM generic define except gonk and android

Minor fix to disable this patch for Gonk and Android build, which have cpu_android features
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7316b758ef0
https://hg.mozilla.org/mozilla-central/rev/b7316b758ef0
Assignee: nobody → romaxa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.