Devtools API: fix inspectionTarget reject and added primitive commands history to actor-repl example

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: erikvold, Assigned: irakli)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8488956 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1434
Attachment #8488956 - Flags: review?(rFobic)
Luca: Changes looks good but could you please retarget pull to a master branch so we could land it directly ?
Assignee: nobody → rFobic
Flags: needinfo?(luca.greco)
Priority: -- → P1

Comment 3

4 years ago
Created attachment 8493741 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1638

This new pull request is a rebase on master of the previous one:

- "inspection target reject" fix: removed (because it isn't there anymore)
- "simple CommandHistory on examples/actor-repl" change: rebased on master
- minor cleanups (e.g. removed an unused required module)
Attachment #8488956 - Attachment is obsolete: true
Attachment #8488956 - Flags: review?(rFobic)
Flags: needinfo?(luca.greco)

Comment 4

4 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c5d69d713ef764c3f75f0a9ac5056f1a0e7c7bcd
Merge pull request #1638 from rpl/devtools-api/actor-repl-history

fix Bug 1066912 Devtools API: added primitive commands history to actor-repl example and minor cleanup r=@gozala

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.