Closed Bug 1067000 Opened 7 years ago Closed 4 years ago

Add tests for the log viewer

Categories

(Tree Management :: Treeherder: Log Viewer, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: emorley, Unassigned)

References

Details

Bug 1066149 broke the log viewer, but Travis remained green.
We should add some tests for the log viewer that would have caught this.
Priority: -- → P3
Blocks: 1072681
Component: Treeherder → Treeherder: Log Viewer
No longer blocks: 1072681
Priority: P3 → P4
We have an initial proof of concept test in mozwebqa's treeherder-tests which I think would catch this bug, when it gets hooked up/run in CI or on some appropriate interval using stage.
https://github.com/mozilla/treeherder-tests/blob/master/tests/test_unclassified_job.py

It loads the logviewer with a selected unclassified failure, and expects the presence of a valid logviewer job-header container. If I understand correctly the failure was the whole logviewer wasn't loading, so this test should expose it and fail.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.