Closed Bug 1067025 Opened 5 years ago Closed 5 years ago

crash in java.lang.IllegalArgumentException: string must not be null at org.mozilla.gecko.sync.setup.activities.WebURLFinder.<init>(WebURLFinder.java)

Categories

(Firefox for Android :: Overlays, defect, critical)

34 Branch
All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + verified
firefox35 --- verified

People

(Reporter: aaronmt, Assigned: ckitching)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-9f7b3c98-6e8d-4c4c-836c-571392140912.
=============================================================

java.lang.IllegalArgumentException: string must not be null
	at org.mozilla.gecko.sync.setup.activities.WebURLFinder.<init>(WebURLFinder.java:22)
	at org.mozilla.gecko.overlays.ui.ShareDialog.onCreate(ShareDialog.java:97)
	at android.app.Activity.performCreate(Activity.java:5104)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1080)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2227)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2313)
	at android.app.ActivityThread.access$600(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1317)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:152)
	at android.app.ActivityThread.main(ActivityThread.java:5132)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:562)
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:133)
	at dalvik.system.NativeStart.main(Native Method)
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
Thanks, AaronMT.  Looks like ShareDialog needs to be more pessimistic about its incoming intent: this is Android, after all.  ckitching, can you take this?
Flags: needinfo?(chriskitching)
Yup. Should be straightforward, if depressing.
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
Flags: needinfo?(chriskitching)
*sigh*
Attachment #8489202 - Flags: review?(rnewman)
Comment on attachment 8489202 [details] [diff] [review]
Abort when no extra_text present in share dialog

Review of attachment 8489202 [details] [diff] [review]:
-----------------------------------------------------------------

Remember to request uplift to 34 after verification.
Attachment #8489202 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/11b2ef45231d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Report says 34 affected, I don't see this reflected in crash stats. Does this need to be uplifted?
Flags: needinfo?(aaron.train)
Share overlay landed in 34, code is affected:

http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/base/overlays/ui/ShareDialog.java#97
Component: Android Sync → Overlays
Product: Android Background Services → Firefox for Android
Hardware: ARM → All
Version: Firefox 35 → Firefox 34
Comment on attachment 8489202 [details] [diff] [review]
Abort when no extra_text present in share dialog

Approval Request Comment
[Feature/regressing bug #]:
  Lack of input validation in initial landing of share handler.

[User impact if declined]:
  Crashes from certain shares.

[Describe test coverage new/current, TBPL]:
  Manual.

[Risks and why]: 
  Low risk: a small refactor and an isEmpty check.

[String/UUID change made/needed]:
  None.
Attachment #8489202 - Flags: approval-mozilla-aurora?
Flags: needinfo?(aaron.train)
Comment on attachment 8489202 [details] [diff] [review]
Abort when no extra_text present in share dialog

Aurora+
Attachment #8489202 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
There have been 0 crashes reported for this signature in the last week.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.