Closed Bug 1067046 Opened 8 years ago Closed 8 months ago

Don't try to shut down the PBackground thread until application shutdown

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
The PBackground thread stays alive as long as you have PBackground actors. With IndexedDB now using PBackground the main thread actor will stay alive until app shutdown, so there's no real point trying to reclaim the PBackground thread until app shutdown any more. This will also let us simplify PBackground actors a bit.
Attachment #8489045 - Flags: review?(khuey)
Comment on attachment 8489045 [details] [diff] [review]
Patch, v1

Review of attachment 8489045 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we need sShutdownTimer at all?  Why not just create it when we need it?
Attachment #8489045 - Flags: review?(khuey) → review+

The code there changed significantly in the meantime and there is no more ShutdownBackgroundThread here. I assume we improved the situation in some other way.

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.