1067200 - Override in chrome.manifest not restartless for native browser files in bootstrapped add-ons

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Patrick Storz]

It seems overriding native browser files by using chrome registration from a bootstrapped add-on does only work after a restart, rendering the "restartless" approach useless.

Here's what I tried in my "chrome.manifest":
    skin myaddon classic/1.0 skin/
    override chrome://global/skin/TopLevelImageDocument.css
             chrome://myaddon/skin/TopLevelImageDocument.css

The skin folder of my bootstrapped add-on contains the respective "TopLevelImageDocument.css" and the override actually works - but only after a Firefox restart.
Also on uninstalling/deactivating the add-on, a Firefox restart is required to disable the override.


I don't know if this is how overrides are supposed to work in restartless add-ons but I think this should be either
a) fixed, or
b) documented accordingly if the above is actually not supposed to work.

Comment 1

[Dave Garrett]

The 'override' instruction is actually supposed to work in restartless addons, according to MDN:
https://developer.mozilla.org/en-US/docs/Chrome_Registration#Instructions_supported_in_bootstrapped_add_ons

Comment 2

[Patrick Storz]

Some new insights I collected:
- Actually the override seems to work (also without the need for a restart)
- When I open the overridden resource URI (chrome://global/skin/media/TopLevelImageDocument.css)
  in the browser I'm presented with the expected file content
  (depending on whether my add-on is enabled or disabled)

However the override is not taking effect on any "TopLevelImageDocument". Those still use the CSS file that was active on Firefox startup (therefore mirroring the state of the add-on on startup).
Reloading / opening of new tabs or browser windows does not update the CSS, only a browser restart works.

Does anybody know what is going on here?

Comment 3

[Andrew Swan [:aswan]]

We no longer support any form of chrome registration from addons