Closed
Bug 1067229
Opened 10 years ago
Closed 10 years ago
nsIXULAppInfo::ID fails in content process.
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
People
(Reporter: markh, Assigned: markh)
References
Details
(Whiteboard: [e10s])
Attachments
(1 file, 1 obsolete file)
6.23 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #886903 +++ The file addon-sdk/source/modules/system/XulApp.js makes extensive use of nsIXULAppInfo::ID(). Devtools makes use of this module, and this fails when e10s is enabled as it imports the module in the content process, and nsIXULAppInfo::ID fails with NS_ERROR_NOT_AVAILABLE in that context. While it is probably possible to fix that for the devtools specific case, it seems reasonable that content-process code might want to know the ID of the app - hence this bug. Bug 886903 sent more AppInfo data to the child process, but the "ID" of the app wasn't covered. This patch is almost identical to the one there, marshaling this ID to the child process so it can return it.
Attachment #8489218 -
Flags: review?(josh)
Updated•10 years ago
|
Attachment #8489218 -
Flags: review?(josh) → review+
Updated•10 years ago
|
Component: Embedding: GRE Core → DOM: Content Processes
Comment 1•10 years ago
|
||
Want to make this do the vendor property as well?
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Josh Matthews [:jdm] from comment #1) > Want to make this do the vendor property as well? Yeah, good idea.
Attachment #8489218 -
Attachment is obsolete: true
Attachment #8489706 -
Flags: review?(josh)
Updated•10 years ago
|
Attachment #8489706 -
Flags: review?(josh) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c45f715f529c
Status: NEW → ASSIGNED
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Comment 5•10 years ago
|
||
sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48355185&tree=Fx-Team
Blocks: 1037235
Assignee | ||
Comment 6•10 years ago
|
||
So this is really blocked by bug 902165, and I'll mark bug 1070810 as invalid.
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7792d7f25f1e - try at https://tbpl.mozilla.org/?tree=Try&rev=a606605886f6
Updated•10 years ago
|
Iteration: --- → 35.2
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7792d7f25f1e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•