1067231 - [Keyboard][Text Selection] Tapping the touch caret should show Paste utility bubble if clipboard is not empty

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P1)

Description

[Omega Feng [:Omega] [:馮於懋]]

[Steps To Reproduce]
1. In an input, copy a word
2. Tap the input again to show Paste utility bubble
3. Tap Paste to paste the string from clipboard
4. Tap the input again, and make sure the touch caret is visible and Paste utility bubble is invisible
5. Tap the touch caret

[Actual Result]
The Paste utility bubble doesn't show up.

[Expected Result]
The Paste utility bubble should show up.

Device: Flame
OS Version: 2.2.0.0-prerelease
Platform Version: 35.0a1
Build Identifier: 20140908160203
Git Commit Info: 2014-09-13 17:51:21 (0f45989d)

Comment 1

[Peter Chang[:pchang]]

The root cause of this problem is no selection change event with mouse_up.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1027631

Send a chrome only event when touch caret is tapped. So that gaia could show bubble when touch caret is tapped base on this event.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: gaia-part

Hi, George
This is gaia part for this bug. I need your help for applying this patch. Thanks

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Morris,
could I have your feedback on this patch? Thanks.

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8501625 [details] [review]
PR to master

Comment in github.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try run: 
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6833288ece92

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5d276cd3759b

I had to fix the bug number in this commit message. Please double-check them in the future beforehand.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for non-unified bustage. Don't forget to fix the bug number in the commit message while you're at it.
https://hg.mozilla.org/integration/b2g-inbound/rev/fe1a9613e61b

/builds/slave/b2g-in-lx-d-000000000000000000/build/layout/base/TouchCaret.cpp: In member function 'void mozilla::TouchCaret::DispatchTapEvent()':
/builds/slave/b2g-in-lx-d-000000000000000000/build/layout/base/TouchCaret.cpp:869:12: error: 'Event' was not declared in this scope

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5d276cd3759b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

mcMerge got a bit confused with the backouts, wrong bug #, etc.

Comment 12

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1067231 v2 (carry r+: ehsan)

Sorry about the backout. Re-upload patch with correct commit message.

new try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d4ab4bf180fe

Comment 13

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1067231 v3 (carry r+: ehsan)

Fix build failed,

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4557ca40d8df

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad33a3d9202c

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad33a3d9202c