Closed
Bug 1067264
Opened 10 years ago
Closed 10 years ago
Remove blur delay in keyboard app
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: timdream, Assigned: mnjul)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
With bug 1057898 in Gecko we no longer need a delay timer in StateManager. We can start invaliding the state when active=false instantly. John, would you like to take this bug?
Flags: needinfo?(jlu)
Assignee | ||
Comment 2•10 years ago
|
||
Getting it tested (esp. for UI/Integration).
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S5 (26sep)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8492029 [details] [review] Patch (PR @ GitHub) Hi Tim, This patch tests good on TBPL, so I'm requesting review. Again I've tested the patch manually and made sure rapid switching behaves as expected. Unit tests for rapid de/activation have been removed as it should now be guarded by Gecko (rendering it useless that we test the behavior with Gaia-side unit tests). Thanks!
Attachment #8492029 -
Attachment description: Proposed Patch (PR @ GitHub) → Patch (PR @ GitHub)
Attachment #8492029 -
Flags: review?(timdream)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8492029 [details] [review] Patch (PR @ GitHub) Thanks.
Attachment #8492029 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Final TBPL testing before landing: https://tbpl.mozilla.org/?rev=d7a545abc17602c05666109e903de3e093a02697&tree=Gaia-Try
Comment 6•10 years ago
|
||
Has this been tested on slow devices (Dolphin or something) and we're sure that the keyboard doesn't pop down in between?
Flags: needinfo?(jlu)
Assignee | ||
Comment 7•10 years ago
|
||
Well I only have Buri, and it tests good. No pop down.
Flags: needinfo?(jlu)
Assignee | ||
Comment 8•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/46db9f5bef3bd837ec77c6587cf4ab33eb20b28d Got a Gij failure out there but that's present on PRs before and after mine.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•