Closed Bug 106728 Opened 23 years ago Closed 23 years ago

New Composer doesn't work from Composer window

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: sujay, Assigned: cmanske)

Details

(Whiteboard: EDITORBASE [QAHP])

Attachments

(1 file, 1 obsolete file)

Fix
1.49 KB, patch
cmanske
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review 
using 10/25 trunk build

1) launch netscape
2) launch composer
3) click on New

doesn't bring up new window. also File | New COmposer page doesn't work
either.
Kathy and I were also seeing that yesterday, though we thought it might just be
part of the focus problems we were seeing (toolbar not enabled until you type
something).  As far as we know it's new on the 10/24 build.
can we please get this fixed....bad regression...
Strange, but the New command seems to be working in my debug build today.
Maybe related to bug 106733?
Status: NEW → ASSIGNED
Whiteboard: EDITORBASE
Target Milestone: --- → mozilla0.9.6
The patch may be unrelated to the reported problem, but the code for cmd_newEditor
is in utilityOverlay.xul and utilityOverlay.js, so the code we had in editor
was not used and is misleading.
Keywords: patch, review
Whiteboard: EDITORBASE → EDITORBASE, FIX IN HAND, need r=,sr=
Comment on attachment 55368 [details] [diff] [review]
Remove unused nsNewEditorCommand from Composer code

sr=kin@netscape.com
Attachment #55368 - Flags: superreview+
Uh that should've been an sr=kin@netscape.com as long as mail compose isn't
relying on that command.
Whiteboard: EDITORBASE, FIX IN HAND, need r=,sr= → EDITORBASE, FIX IN HAND, need r=
All modules tested, and the File | New | Blank window to edit command works 
everywhere after removing Composer's nsNewEditorCommand command
The original bug seems to have disappeared on its own or was fixed by some 
other problem. But the unused command was removed as a generally "good thing
to do."
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
Whiteboard: EDITORBASE, FIX IN HAND, need r= → EDITORBASE
verified.
Status: RESOLVED → VERIFIED
REOPEN...still not working in 10/31 trunk build on windows.
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Frustrating. Definitely not an editor problem! Does not occur in build from 
10/29.
Status: REOPENED → ASSIGNED
Keywords: patch, review
Clarifying the summary
Summary: New doesn't work → New Composer doesn't work from Composer window
I can't reproduce this in my debug build; tree pulled at 2pm 10/31/01

I am still seeing this problem on Win 2k using yesterday's trunk build (2001103103).
I also still see this problem in today's 11/1 trunk build.
its definitely a problem.
Upon further consideration, I'd like it if you didn't remove these lines:
-  <separator class="groove"/>

in EdHLineProps.xul, EdInsertChars.xul, and EdPageProps.xul.
They are all near the bottom of the dialog, just above:
-  <!-- from global dialogOverlay -->
-  <hbox id="okCancelButtonsRight"/>


Please ignore last comment -- wrong bug!
cc: Tucson QA on this bug...
Whiteboard: EDITORBASE → EDITORBASE [QAHP]
John/Sara, any idea why this is broken in composer?
I don't specifically know. However, if you look at the dom tree with the DOM 
Inspector, somehow the original declaration (from editorOverlay.xul) has been
stripped down to the equivalent of this: 
   "<menuitem acceltext="Ctrl+Shift+N"/>"

So, with no command to process, you get no action from clicking that menuitem.
But, don't know why the model has been broken in that way. I'd review the 
checkins for the window of time in which this got broken.
Comment on attachment 55368 [details] [diff] [review]
Remove unused nsNewEditorCommand from Composer code

This change was checked in
Attachment #55368 - Attachment is obsolete: true
Attached patch Fix — — Splinter Review 

    
    

    
  
This turned out to be easy!
Keywords: patch, 
          
            review
Whiteboard: EDITORBASE [QAHP] → EDITORBASE [QAHP], FIX IN HAND, need r=,sr=

    
  

        Attachment #56499 -
        Flags: review+

    
  
Whiteboard: EDITORBASE [QAHP], FIX IN HAND, need r=,sr= → EDITORBASE [QAHP], FIX IN HAND, need sr=

    
  

        Attachment #56499 -
        Flags: superreview+

    
  
Whiteboard: EDITORBASE [QAHP], FIX IN HAND, need sr= → EDITORBASE [QAHP], FIX IN HAND

    
    

    
  
is this bug fixed yet?


    
    

    
  
This appears to be fixed, and is working for me using the 2001110603 build on
Win 2k.

    
    

    
  
this also worksforme now in the 11/6 builds on windows.



    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
  
Keywords: patch, 
          
            review
Whiteboard: EDITORBASE [QAHP], FIX IN HAND → EDITORBASE [QAHP]

    
    

    
  
verified in 11/6 build.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: