[WAP push][CP] Remove wrong PIN popup and show error in the form.

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::Wappush
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: albert, Assigned: albert)

Tracking

unspecified
2.1 S5 (26sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
gsvelto
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
STR
1. Send a CP message (USERPIN security)
2. Insert wrong PIN

EXPECTED
Show 'PIN is not correct' under the PIN input according to the specs.

ACTUAL
Error message is shown using a popup.
(Assignee)

Updated

4 years ago
Blocks: 1067276
(Assignee)

Updated

4 years ago
Assignee: nobody → alberto.crespellperez
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8492117 [details] [review]
Patch
Attachment #8492117 - Flags: review?(gsvelto)
Comment on attachment 8492117 [details] [review]
Patch

Looks good to me, thanks! I've re-triggered the integration tests which had failed for an unrelated reason, merge at will on a green Try.
Attachment #8492117 - Flags: review?(gsvelto) → review+
(Assignee)

Comment 3

4 years ago
Thank you, Try is green now.
(Assignee)

Comment 4

4 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/a3e03d244c525593645231568e77d026e8da9106
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-b2g-v2.2: --- → fixed
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.