Closed Bug 1067294 Opened 9 years ago Closed 9 years ago

[WAP push][CP] Remove wrong PIN popup and show error in the form.

Categories

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Wappush
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: albert, Assigned: albert)

References

Details

Attachments

(1 file)

Patch
46 bytes, text/x-github-pull-request
gsvelto
: review+
Details | Review 
STR
1. Send a CP message (USERPIN security)
2. Insert wrong PIN

EXPECTED
Show 'PIN is not correct' under the PIN input according to the specs.

ACTUAL
Error message is shown using a popup.
Blocks: 1067276
Assignee: nobody → alberto.crespellperez
Status: NEW → ASSIGNED
Attached file Patch — 

        Attachment #8492117 -
        Flags: review?(gsvelto)

    
    

    
  
Comment on attachment 8492117 [details] [review]
Patch

Looks good to me, thanks! I've re-triggered the integration tests which had failed for an unrelated reason, merge at will on a green Try.

        Attachment #8492117 -
        Flags: review?(gsvelto) → review+

    
    

    
  
Thank you, Try is green now.

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/a3e03d244c525593645231568e77d026e8da9106
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          status-b2g-v2.2:
          --- → fixed
Target Milestone: --- → 2.1 S5 (26sep)

          You need to log in
          before you can comment on or make changes to this bug.