Closed Bug 1067296 Opened 10 years ago Closed 10 years ago

[WAP push][CP] Modify style and locales of finish popup

Categories

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Wappush
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: albert, Assigned: albert)

References

Details

Attachments

(2 files, 2 obsolete files)

UX Spec. OMA Client Provisioning
1.98 MB, application/pdf
Details
Patch v2
46 bytes, text/x-github-pull-request
gsvelto
: review+
Details | Review 
STR
1. Send a CP message (USERPIN security)
2. Insert correct PIN
3. Confirm save APN

EXPECTED
Toast with 'APN(s) added' message is shown.

ACTUAL
Same message is shown using a popup.
Blocks: 1067276
Assignee: nobody → alberto.crespellperez
Status: NEW → ASSIGNED
Attached file Patch (obsolete) — 

    
    

    
  
Specs say that app should be closed while the toast continues being visible, but this can't be done because toast disappears when app is closed. Problem reported to UX (Pau).
Flags: needinfo?(b.pmm)

    
    

    
  

      
      
      
      

        Attached file
          
        OMA_CP_v1.pdf (obsolete)
        — 
      

    


  
Here I attach the spec already updated. We can solve the toast issue by adding a confirmation dialog. Pretty similar to what is currently implemented.

Thanks!
Flags: needinfo?(b.pmm)

    
  
Summary: [WAP push][CP] Use toast instead of popup message when APN is stored → [WAP push][CP] Modify style and locales of finish popup

    
    

    
  
Summary changed according to new specs.

    
  

        Attachment #8493143 -
        Flags: review?(gsvelto)

    
    

    
  


  
Here's an update of the current spec.

        Attachment #8495146 -
        Attachment is obsolete: true

    
  

        Attachment #8493143 -
        Attachment description: Patch (WIP) → Patch

    
    

    
  
Patch updated according to last spec update.

    
    

    
  
Comment on attachment 8493143 [details] [review]
Patch

Changing a localization string content requires changing the id too, see here:

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings

Please change the id to 'cp-finish-confirm-dialog-message-apn-saved' or something along the lines and ask for review again.

        Attachment #8493143 -
        Flags: review?(gsvelto) → review-

    
    

    
  
Comment on attachment 8493143 [details] [review]
Patch

Changes from comment 7 (and rebase)

        Attachment #8493143 -
        Flags: review- → review?(gsvelto)

    
    

    
  
rebased

    
    

    
  

      
      
      
      

        Attached file
          
        Patch v2
        — 
      

    


  
Created new PR because the other was closed due to tree stability issues.

        Attachment #8493143 -
        Attachment is obsolete: true

        Attachment #8493143 -
        Flags: review?(gsvelto)

        Attachment #8500914 -
        Flags: review?(gsvelto)

    
    

    
  
Comment on attachment 8500914 [details] [review]
Patch v2

LGTM, sorry for the delay.

        Attachment #8500914 -
        Flags: review?(gsvelto) → review+

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/6dfc0e601c716bf04143950c681a90ceec91bc6a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          status-b2g-v2.2:
          --- → fixed
Target Milestone: --- → 2.1 S6 (10oct)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: