1067303 - [Contacts] deferred actions / migrator is not working. errors in console are found

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR: Run the Contacts App 

Then in the console it starts appearing different errors:

E/GeckoConsole(22192): [JavaScript Error: "TypeError: fb.utils is undefined" {file: "app://communications.gaiamobile.org/contacts/js/migrator.js" line: 27}]
E/GeckoConsole(22192): [JavaScript Error: "TypeError: fbutils is undefined" {file: "app://communications.gaiamobile.org/contacts/js/deferred_actions.js" line: 36}]

Comment 1

[Jose Manuel Cantera]

[Blocking Requested - why for this release]:

Uncaught errors in console

Comment 2

[Jose Manuel Cantera]

Attachment: 24055.html

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

This bug can cause data lose due to problems to migrate from 1.X versions to 2.X

Blocking cause of that.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8489404 [details]
24055.html

Really good job, just left a couple of nits related to the unit test part.

Comment 5

[Jose Manuel Cantera]

landed in master:

https://github.com/mozilla-b2g/gaia/commit/ebb3f6c3de5e1e6b1642a167866b47081db7d263

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Jose, could you ask for the 2.1 approval?

Thanks!

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8489404 [details]
24055.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Contacts-FTU IAC removal
[User impact] if declined: Very high. Loss of data
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.1 uplift.

Comment 9

[Jose Manuel Cantera]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> Needs rebasing for v2.1 uplift.

Ryan, This bug depends on two other bugs that would need also uplifting to v2.1

thanks

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/e7f7c8cd784cc8a93c343ae900f43372b3d4cda7

Comment 11

[Lancy(Leave from Mozilla)]

Hi Jose,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!

Comment 12

[Jose Manuel Cantera]

(In reply to Lancy from comment #11)
> Hi Jose,
> 
> Could you please provide the detailed reproduce steps or video for me to
> verify this bug?
> Thank you very much!

You can launch the Contacts App and see that in the logcat No contacts app related error log appears. 

thanks!

Comment 13

[Lancy(Leave from Mozilla)]

Attachment: logcat_Flame2.1.txt

This issue has been verified successfully on Flame 2.1 & Flame 2.2.
There is no contacts app related error log in logcat.

See the attachment: logcat_Flame2.1.txt & logcat_Flame2.2.txt.

Flame 2.1 build:
Gaia-Rev        77c57eb8a985d5cbd34a597fb1b978ba6e205af6
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f05d0a2d2378
Build-ID        20150120001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150120.035022
FW-Date         Tue Jan 20 03:50:33 EST 2015
Bootloader      L1TC000118D0

Flame 2.2 build:
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5d7497ce4cc7
Build-ID        20150120002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150120.035540
FW-Date         Tue Jan 20 03:55:51 EST 2015
Bootloader      L1TC000118D0

Comment 14

[Lancy(Leave from Mozilla)]

Attachment: logcat_Flame2.2.txt