Closed Bug 1067312 Opened 5 years ago Closed 5 years ago

embedding/test/test_bug293834.html fails with content sandbox and low integrity temp

Categories

(Core :: Security, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

embedding/test/test_bug293834.html fail with the Windows content sandbox enabled, because the low integrity temp directory doesn't exist and it assumes that it does.

As other things might also assume this, I think it's best to create the directory when it is original provided by the directory service.
Sorry, forgot to clear the CC list.
Assignee: nobody → bobowencode
This creates the directory as it is requested.

Nathan hopefully you're OK to review this. :)

Try push with the sandbox enabled:
https://tbpl.mozilla.org/?tree=Try&rev=0d7ab2a9c560

Another similar try push without the sandbox:
https://tbpl.mozilla.org/?tree=Try&rev=2fa49c07aa60
Attachment #8489435 - Flags: review?(nfroyd)
Just realised it was the opt version of this test that was failing in M(4):
https://tbpl.mozilla.org/?tree=Try&rev=c4bfb68f28a0
Attachment #8489435 - Flags: review?(nfroyd) → review+
This change is in code that will only run on Windows and only when the content sandbox is enabled, which it isn't by default.

Here's a simple try push without the sandbox enabled:
https://tbpl.mozilla.org/?tree=Try&rev=2fa49c07aa60

And here's one with the sandbox enabled that shows M(4) passing (the M(1) failure is not related):
https://tbpl.mozilla.org/?tree=Try&rev=c4bfb68f28a0

Thanks.
Keywords: checkin-needed
I'm on PTO for a week so, I'll re-request when I get back.
Keywords: checkin-needed
Just checked this still applies cleanly to m-c.

See comment 4 for try pushes, thanks.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1b7329c2d3d3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.