1067342 - "Share This Page" icon missing in Customize mode

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Dirkjan Ochtman (:djc)]

When invoking Customize mode, the icon for the "Share This Page" button seems to be missing (when that button is not on the toolbar, i.e. it's in Additional Tools and Features). When you move it onto the toolbar, it does appear. When you move it back to Additional Tools and Features, it does show up. When you then close and re-open Customize Mode, it also shows up. When you close Firefox and then open it again, then open Customize Mode, it's gone.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0

Comment 1

[Mike Conley (:mconley) (:⚙️)]

What's the expected behaviour here, mixedpuppy?

Comment 2

[Shane Caraveo (:mixedpuppy)]

I cant reproduce.  Are there share providers installed?  Regardless, bug 1014332 will change the updating of the share button, so am not concerned about 35, but if it can repro in 34/33 I'd like to know.

Comment 3

[Dirkjan Ochtman (:djc)]

Nope, I don't have any share providers installed, I think. Those should be listed under Services on about:addons, right?

Comment 4

[Shane Caraveo (:mixedpuppy)]

Hmm, still cant reproduce, but I'm not going to worry about this.  The specific mechanism that I know would be the cause the situation you're describing is replaced with changes I mentioned before (bug 1014332).  

I'm guessing that you installed a share provider at some point, customized the share button to a new location, then removed the share provider.  That is the STR for a bug that had a similar affect you're describing, though that was fixed some time ago.

If you have STR on a clean profile, let me know.

Comment 5

[Shane Caraveo (:mixedpuppy)]

bug 1014332 has been fixed, the button is now a CUI widget so previous hiding/unhiding logic is gone.