130.29 KB, image/png
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
2.00 MB, image/jpeg
172.72 KB, image/png
With the new design landed in bug 1038723, I keep seeing truncated text in Utility tray notifications because of the bigger font we're using (notification time was fixed in bug 1060928). Messages that have been perfectly fine from 1.0 to 2.0 are now badly truncated. In Italian I'm aware of at least 2 (screenshot notification, downloading updates), but I'm sure there are more.
Francesco, can you provide us with some example screenshots?
Created attachment 8489830 [details] screenshot.png These are the two notifications I'm aware of (updated flame on the left, keon right before the update on the right).
Note that the "downloading updates" was already truncated in the previous design.
Eric, can you take a look at this? Perhaps we want to decrease the font size further for the notification info in the tray?
(In reply to Julien Wajsberg [:julienw] from comment #3) > Note that the "downloading updates" was already truncated in the previous > design. Nope. That's a … part of the string to indicate 'action in progress', not a truncation http://transvision.mozfr.org/?recherche=download+in+corso%E2%80%A6&repo=gaia&sourcelocale=en-US&locale=it&search_type=strings
Created attachment 8491405 [details] [Spec] Notifications Sytem Spec.jpg Hi, I've updated the spec to reduce the size of the font (for the first line). This should bring things back to the way they used to be. The font is now 15.333px on HVGA (23px on Flame). Please let me know if there are any questions, thanks!
Alberto, can you help fix this one up?
Created attachment 8492947 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24270 I'm a little bit confused about the spec, as it doesn't say 15.33px for the first line, but I guess it was a mistake. Eric, could you please review?
Created attachment 8493027 [details] [Spec] Notifications Sytem Spec Updated the spec, sorry for the confusion Alberto. The time stamp should stay as is and the 1st line should only be updated. My comment now matches the spec :). Let me know if you have any questions.
(In reply to Eric Pang [:epang] from comment #9) > Created attachment 8493027 [details] > [Spec] Notifications Sytem Spec > > Updated the spec, sorry for the confusion Alberto. The time stamp should > stay as is and the 1st line should only be updated. My comment now matches > the spec :). Let me know if you have any questions. just saw the ui-review flag. Will take a look when I get a chance! thx
Created attachment 8493048 [details] 2014-09-22-10-43-49.png Hey Alberto, looks like the 'Update Available' text isn't resized. Can you take a look? Also, can you check other possibilities to makes sure all notifications are updated? Thanks!
Just updated the flag. Will add some tests before r? Thanks!
^ Last comment wasn't supossed to go here :S
Hi Alberto, the spacing between the 1st and 2nd line is looking tight. Can you check that it's 1.8rem from baseline to baseline and vertically centered in the space? Thanks!
Hey Eric, just updated the patch. Thanks!
Comment on attachment 8492947 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24270 Looks good now, thanks Alberto!
Comment on attachment 8492947 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24270 Pinging :gmarty, as he worked on the utility tray :)
Comment on attachment 8492947 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24270 Looks good to me. I left a minor comment on Github to avoid conflict with https://bugzilla.mozilla.org/show_bug.cgi?id=1062314 (not sure which one of these two will land first). Thanks Alberto!
[Blocking Requested - why for this release]: Low risk and fixes a UI problem
Comment on attachment 8492947 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24270 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1038723 [User impact] if declined: Truncated notification titles [Testing completed]: Manual testing [Risk to taking this patch] (and alternatives if risky): Low risk, css only [String changes made]: -
Not blocking but lets do the approval process.
This issue is verified on Flame 2.1: Flame 2.1 KitKat Base (319mb)(Full Flash) Environmental Variables: Device: Flame 2.1 BuildID: 20141007000203 Gaia: 7f738edf66b9298bceef8a4981d05d04fd04e540 Gecko: b9d04c58580a Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 The font size is reduced properly on Utility Tray. ======================================================== This issue fails to verify on Flame 2.2. Environmental Variables: Device: Flame 2.2 Master BuildID: 20141006040204 Gaia: 470826d13ae130a5c3d572d1029e595105485fb0 Gecko: e0d714f43edc Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 The font size for update-related notifications is bigger than the rest. Filed a new bug 1079394.