1067358 - Partner repack changes for web.de, gmx, mail.com and 1&1 (Firefox 33)

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mike Kaply [:mkaply]]

This will contain partner changes for Firefox 32 for web.de, gmx and mail.com

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Search Engine update

Just an update to the search engine.

Some very small other changes will be coming.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8489361 [details] [diff] [review]
Search Engine update

r+ assuming you really mean to remove SearchForm.  

Any chance those urls could be https?  Seems like the suggestions url cannot, but the others could.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Diff of changes from 2.11.2 to 2.11.3

These are our extension changes. This is a diff of our source tree, since the actual changes will be in the JAR.

The changes are:

0e22bf8 search #1653 - Use URL resolver for new tab and search box
6e533f7 search #1650 - Make search icon go to search when field is empty - CAMCBR-1992
2d384a6 horoscope #1652 - Completely remove horoscope
eb6806f prefs #1626 - Remove features tab
dedff8d weather/ticker #1626 - Completely remove weather and ticker
8c5690a email #1569 - Accidentally left in include of email-common.js
6b23396 startpage #1569 - Larger font, use image for search
568b7c5 startpage #1569 - Port Chrome new tab page to Firefox start page
e32e6cd homebutton #1652 - Re-add news and weather as simple links in homebutton - CAMCBR-2041 and -2042
b53136e minimode #1652 - Add minimode button to toolbar
44061ec webapps #1652 - Remove SMS menuitem, rename button

Comment 4

[Mike Kaply [:mkaply]]

So is Shane responsible for all our reviews from now on?

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to Mike Kaply (:mkaply) from comment #4)
> So is Shane responsible for all our reviews from now on?

I'll be working with mconnor on the repacks as well as other stuff, that's not to say I'd be the only person doing reviews.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8492172 [details] [diff] [review]
Diff of changes from 2.11.2 to 2.11.3

I don't see any issues here, so r+

Comment 7

[Shane Caraveo (:mixedpuppy)]

One comment on future work if it fits in...it might be good to use the CustomizableUI widgets for your toolbar buttons.

Comment 8

[Mike Kaply [:mkaply]]

> Any chance those urls could be https?  Seems like the suggestions url cannot, but the others could.

I'll inquire about this with the client for the next release.

> One comment on future work if it fits in...it might be good to use the CustomizableUI widgets for your toolbar buttons.

Once Firefox 24 is out of support... :)

Comment 9

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/build/partner-repacks/rev/59db6817d961

Comment 10

[Mike Kaply [:mkaply]]

The builds here:

https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/33.0b8-candidates/build1/partner-repacks/

Don't have our new code in them, yet they were built 6 days after the checkin.

Comment 11

[Mike Kaply [:mkaply]]

I opened bug 1077374 for this.

Comment 12

[Shane Caraveo (:mixedpuppy)]

Mike, are current builds ok?

Comment 13

[Mike Kaply [:mkaply]]

Yep. It's all good.