Closed Bug 1067420 Opened 10 years ago Closed 10 years ago

The UI frequently stops showing new pushes and job results until refreshed (Socket.IO issues)

Categories

(Tree Management :: Treeherder, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: jeads)

References

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
camd
: review+
Details | Review
During the work week Ryan experienced the UI frequently not showing new pushes and job results. A refresh of the page caused them to appear.

The conclusion was that either:
a) The socket.io notifications were getting dropped.
b) The UI wasn't handling/rendering them correctly.

In addition, the current socket.io implementation has no handing for things like:
* Network drops
* Changing wifi networks
* Putting the laptop to sleep
* Opening firefox with the tab pinned from the session before

We need to either make our use of socket.io reliable or else switch to setTimeout polling. We also need to handle missed updates properly and catch up everything that changed in the interim.

Constantly refreshing tabs is not really practical, since:
* It's hard to know _when_ you're missing new pushes/jobs (if this were a glitches in the UI where it stopped rendering at all, at least we'd know and could refresh just as needed).
* Refreshing a tab resets state (filters, number of pushes displayed, current scoll position etc)
* Sheriffs typically have open a lot of TBPL/treeherder tabs, so having to refresh and lose state for all of them every 5-10mins is a pain.

...as such this is a blocker.

jeads said he was leaning towards just replacing socket.io with setTimeouts. If so, that may also fix bug 1065576.
Summary: The UI frequently stops showing new pushes and job results → The UI frequently stops showing new pushes and job results until refreshed
Summary: The UI frequently stops showing new pushes and job results until refreshed → The UI frequently stops showing new pushes and job results until refreshed (Socket.IO issues)
Blocks: 1065576
Assignee: nobody → jeads
Status: NEW → ASSIGNED
Attached file PR#190
Attachment #8491149 - Flags: review?(cdawson)
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/b734674ab9cf01e09100ee32192be54d80dfb5b6
Bug 1067420 - The UI frequently stops showing new pushes and job results

https://github.com/mozilla/treeherder-ui/commit/344cc503aac76ecc9a0558710dd8546c4f2e0948
Bug 1067420 - Added polling handling for first resultSet in a repository

https://github.com/mozilla/treeherder-ui/commit/48df90c6fdef779c2c1e223e5dd90cc9237b98d1
Bug 1067420 - Use rootScope.repoName property

https://github.com/mozilla/treeherder-ui/commit/b49197196256ee3145e6ccc77eb7315b72870cbd
Merge pull request #190 from mozilla/resultset-polling

Bug 1067420 - The UI frequently stops showing new pushes and job results
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/baf222b73a567fe263d3f0c0239444ac0b9aca15
Bug 1067420 - Modified the polling intervals to reduce load

https://github.com/mozilla/treeherder-ui/commit/9f7f8ddbc57131458ba43b375cddd5a575a8b08d
Merge pull request #194 from mozilla/resultset-polling-update

Bug 1067420 - Modified the polling intervals to reduce load
Attachment #8491149 - Flags: review?(cdawson) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1071002
Depends on: 1071081
Depends on: 1071306
No longer depends on: 1071306
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0ffc4329aa786e863487bcfc9fb693f08217ac55
Bug 1067420 - The UI frequently stops showing new pushes and job results

https://github.com/mozilla/treeherder/commit/8e3aacd69d2ff61fb1e8784caba234e2b9ade98d
Bug 1067420 - Added polling handling for first resultSet in a repository

https://github.com/mozilla/treeherder/commit/0fba35c13738ac079d3feb25ac2a25a15173f814
Bug 1067420 - Use rootScope.repoName property

https://github.com/mozilla/treeherder/commit/f771cacdf8dd051e06249f800cae6e8f9625691a
Merge pull request #190 from mozilla/resultset-polling

Bug 1067420 - The UI frequently stops showing new pushes and job results

https://github.com/mozilla/treeherder/commit/55f39843cf9b28639219c296034de805098997cc
Bug 1067420 - Modified the polling intervals to reduce load

https://github.com/mozilla/treeherder/commit/514d0c24050e1d3da2555c26a3fc4f022408f746
Merge pull request #194 from mozilla/resultset-polling-update

Bug 1067420 - Modified the polling intervals to reduce load
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: