Closed
Bug 1067478
Opened 10 years ago
Closed 10 years ago
Native FxA (navigator.mozId.watch/navigator.mozId.request) silently failing
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: ashort, Assigned: ferjm)
References
Details
Attachments
(1 file)
Investigation of bug 1060377 indicates that calling the FxA APIs in the Marketplace privileged app does not result in identity-related events being dispatched correctly in B2G internals.
Comment 1•10 years ago
|
||
Here is the problem:
1) Content calls the navigator.[mozI]d.watch() API here:
https://github.com/mozilla/fireplace/blob/master/src/media/js/commonplace/login.js#L267
2) The window-process API implementation lobs a message to its parent process here:
https://github.com/mozilla/gecko-dev/blob/master/dom/identity/nsDOMIdentity.js#L151
3) Gecko receives the message here:
https://github.com/mozilla/gecko-dev/blob/master/dom/identity/DOMIdentity.jsm#L301
Unfortunately, the .target attribute of the message is an empty object. The code in 2) and 3) is stable and thoroughly tested. We need help from someone who understands B2G's nsIMessage implementation determining what is different in 1).
Comment 2•10 years ago
|
||
[Blocking Requested - why for this release]: having Marketplace use Firefox Accounts is a 2.1 goal and if we don't get this working will be string changes.
blocking-b2g: --- → 2.1?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
Assignee | ||
Comment 3•10 years ago
|
||
The appropriate permission name for privileged apps is "moz-firefox-accounts" [1]. This patch fixes the issue for me.
[1] https://mxr.mozilla.org/mozilla-central/source/dom/apps/PermissionsTable.jsm#407
Attachment #8489558 -
Flags: review?(ashort)
Reporter | ||
Comment 4•10 years ago
|
||
Thanks, that solves the issue for me as well. Is this permission name documented anywhere...?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Thanks Allen.
(In reply to Allen Short [:ashort] from comment #4)
> Thanks, that solves the issue for me as well. Is this permission name
> documented anywhere...?
It was incorrectly documented at https://developer.mozilla.org/en-US/docs/Firefox-Accounts-on-FirefoxOS I've just fixed it as well.
Assignee | ||
Updated•10 years ago
|
Attachment #8489558 -
Flags: review?(ashort)
Comment 6•10 years ago
|
||
Making sure QA verifies this post-landing on 2.1
blocking-b2g: 2.1? → 2.1+
Keywords: verifyme
Comment 7•10 years ago
|
||
Not sure what if anything needs uplift here?
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Flags: needinfo?(ferjmoreno)
Target Milestone: --- → 2.1 S5 (26sep)
Assignee | ||
Comment 8•10 years ago
|
||
I think there is nothing to uplift here, but I am not familiar enough with Fireplace to be sure about it.
Flags: needinfo?(ferjmoreno) → needinfo?(ashort)
Reporter | ||
Comment 9•10 years ago
|
||
All I changed was the permission name in the manifest.
Flags: needinfo?(ashort)
Updated•10 years ago
|
Comment 10•10 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #6)
> Making sure QA verifies this post-landing on 2.1
Can we get STRs to verify this bug please?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
Flags: needinfo?(bbajaj)
Comment 11•10 years ago
|
||
(In reply to Yeojin Chung [:YeojinC] from comment #10)
> (In reply to bhavana bajaj [:bajaj] from comment #6)
> > Making sure QA verifies this post-landing on 2.1
>
> Can we get STRs to verify this bug please?
Looks like allen may already verified this, so we are good here. Allen if you need any QA help help feel free to NI Yeojin. Thanks!
Flags: needinfo?(bbajaj)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Reporter | ||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•