Closed Bug 1067479 Opened 8 years ago Closed 8 years ago

gaia-l10n builds for Breton (br) locale

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gueroJeff, Unassigned)

References

Details

Attachments

(1 obsolete file)

No description provided.
Sorry, hit save changes my mistake.

Once the Breton gaia repo is set up, we'd like to provide them with builds too.
Depends on: 1067477
OS: Mac OS X → All
Hardware: x86 → All
Summary: gaia-l1on builds for Breton → gaia-l1on builds for Breton (br) locale
Summary: gaia-l1on builds for Breton (br) locale → gaia-l10n builds for Breton (br) locale
This just needs a patch to the gaia dir, over to FxOS.
Component: General Automation → Gaia
Product: Release Engineering → Firefox OS
QA Contact: catlee
Where in the gaia dir does the locale need to be added? I can take creating the patch and submiting it for review here.
Flags: needinfo?(l10n)
Thanks flod. I just submitted the following pull request

https://github.com/gueroJeff/gaia/commit/f6be093fd62ec833f836b7fce7924b11e433bdb6
I really hope I'm doing this right. Please feel free to let me know if I haven't.
Attachment #8497061 - Flags: review?(stas)
Comment on attachment 8497061 [details]
Adds br to languages_all.json to start nightly Breton builds.

Hey Jeff -- 

The change looks good, but what you linked is a commit in your fork, not a pull request.  You'll need to click the "new pull request" button to create one against Gaia's upstream repo.

Do you want to try doing it?
Attachment #8497061 - Flags: review?(stas)
Comment on attachment 8497061 [details]
Adds br to languages_all.json to start nightly Breton builds.

https://github.com/mozilla-b2g/gaia/pull/24569
Attachment #8497061 - Flags: review?(stas)
Thanks Stas, I wasn't sure if creating the pull request before review was jumping the gun. Hope this is more helpful.
Attachment #8497061 - Attachment mime type: text/plain → text/x-github-pull-request
Comment on attachment 8497061 [details]
Adds br to languages_all.json to start nightly Breton builds.

sry, not a PR. Also obsolete 'cause of tests infra.
Attachment #8497061 - Attachment is obsolete: true
Attachment #8497061 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8497061 - Flags: review?(stas)
Jeff created a new pull request yesterday: https://github.com/mozilla-b2g/gaia/pull/24613

I'll wait for TBPL before merging.
Master: https://github.com/mozilla-b2g/gaia/commit/186f320d9096f5fab060b5248d90d74236393932

Thanks for the patch, Jeff!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.