Add treeherder support for Android instrumentation tests

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nalexander, Assigned: KWierso)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
My jobs appear to be running (\o/) and are currently listed as "U".  I'd like to get names on treeherder whenever is convenient.

The bug for TBPL is Bug 1067480, which is the Android instrumentation analog to Bug 974358.  This bug is sort of an analog of Bug 1060763, except that ticket is not web-platform-tests only.
(Reporter)

Updated

4 years ago
Component: Testing → Treeherder
Product: Firefox for Android → Tree Management
Version: Trunk → unspecified
(Assignee)

Updated

4 years ago
Assignee: nobody → kwierso
(Assignee)

Comment 1

4 years ago
Created attachment 8489631 [details] [review]
Link to pull request 221

I think this is what's needed to add the two tests into a single group, but I haven't managed to have my changes show up on my vagrant instance.
Attachment #8489631 - Flags: feedback?(jeads)
(Assignee)

Comment 2

4 years ago
(In reply to Wes Kocher (:KWierso) from comment #1)
> Created attachment 8489631 [details] [review]
> Link to pull request 221
> 
> I think this is what's needed to add the two tests into a single group, but
> I haven't managed to have my changes show up on my vagrant instance.

If this isn't enough, could we get documentation somewhere on what exactly is involved in adding new tests or groups of tests?
Comment on attachment 8489631 [details] [review]
Link to pull request 221

Let's hold off this until the names in bug 1067480 are finalised.

Also, the PR is missing the grouping change (I'll comment in the PR).
Attachment #8489631 - Flags: feedback?(jeads)
Priority: -- → P2
Status: NEW → ASSIGNED
The TBPL change is now deployed - Wes I don't suppose you could make the tweaks to the PR so we can get this landed? (Unlike TBPL, mis-categorised previously ingested jobs aren't automatically fixed once a change is made, so the less time the ingestion is incorrect, the better). Or I'm happy to make them if you'd prefer? :-)
Flags: needinfo?(kwierso)
Priority: P2 → P1
(Assignee)

Comment 5

4 years ago
Done. Care to take another look?
Flags: needinfo?(kwierso) → needinfo?(emorley)
Could you rebase it on top of the recent changes? :-)
Flags: needinfo?(emorley)
(Assignee)

Comment 7

4 years ago
Done.
Comment on attachment 8489631 [details] [review]
Link to pull request 221

Have left a comment on the PR :-)
Attachment #8489631 - Flags: feedback+
(Assignee)

Comment 9

4 years ago
Comment on attachment 8489631 [details] [review]
Link to pull request 221

I believe I've addressed that comment, and the tests are passing.
Attachment #8489631 - Flags: review?(emorley)
Attachment #8489631 - Flags: review?(emorley) → review+

Comment 10

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/68acafed7ecdd853efcd86621361a8d7acacc3b3
Bug 1067482 - Add support for Android Instrumentation tests

https://github.com/mozilla/treeherder-service/commit/f561d5fc968895a90d7f4872cd439d7cacace1e4
Merge pull request #221 from KWierso/1067482

Bug 1067482 - Add support for Android instrumentation tests
Thanks! :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.