1067485 - Forward/back browser controls do not adjust filters

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

In TBPL, and also for Treeherder for certain param changes, it's possible to go back to previous parameters by using the browser back button (or in my case, the back button on my mouse).

eg:
1) Open http://treeherder-dev.allizom.org/ui/#/jobs?repo=addon-sdk
2) Press the 'u' key to enter only unstarred mode.
3) Press the browser back button 
-> You go back to the view seen before the 'u' key was pressed.

This works ok in treeherder for the above, however does not work for this:
1) Open http://treeherder-dev.allizom.org/ui/#/jobs?repo=addon-sdk
2) Select a job
3) Click the buildername for the job in the job details panel (which causes a filter to be applied with the current job name)
4) Press the browser back button

Expected:
Filter applied in step #3 is removed, since the history API change causes the UI to update.

Actual:
Nothing happens.

Comment 1

[Ed Morley [:emorley]]

(Reducing the number of P1 bugs at any one time, so there are a half dozen or so top issues on which efforts can be focused)

Comment 2

[Jonathan French (:jfrench)]

I just tried this and it seems to be working now for me, I think(?). The filter is removed when I click the back button.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Yeah, this got fixed at some point.

Comment 4

[Jonathan French (:jfrench)]

Cool, marking fixed per above, minus an assignee.