Add allocation profiling to the memory actor

RESOLVED FIXED in Firefox 35

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 35
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Splitting this out from my work in bug 960671 for use in bug bug 1066361.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Posted patch memory-actors.patch (obsolete) — Splinter Review
jryans, this is the same actor patch(es) you reviewed in bug 960671, but I just want to rubber stamp it again since it is in a new bug now. I split the toggling of recording into a start and stop method, as you asked.

This is a combined patch of the allocations changes, the force GC/CC changes, and a tiny method exposing Debugger.Memory.prototype.takeCensus over the RDP. It was getting too hard to keep everything separate, sorry.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cba18023568c
Attachment #8489689 - Flags: review?(jryans)
Comment on attachment 8489689 [details] [diff] [review]
memory-actors.patch

Review of attachment 8489689 [details] [diff] [review]:
-----------------------------------------------------------------

Still seems good to me!
Attachment #8489689 - Flags: review?(jryans) → review+

Comment 3

5 years ago
Unless you're checking this in yourself, I think you should add a commit message to the patch.
Flags: needinfo?(nfitzgerald)
remote:   https://hg.mozilla.org/integration/fx-team/rev/cc361e77343d
Flags: needinfo?(nfitzgerald)
Keywords: checkin-needed
Whiteboard: fixed-in-fx-team
Whiteboard: fixed-in-fx-team → [fixed-in-fx-team]
sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48249937&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
Hrm, I can't repro locally. Digging into the test logs...
Ok just adding a check that the frame does exist in test_memory_allocations_01.html.

Let's see how this turns out: https://tbpl.mozilla.org/?tree=Try&rev=d00453950900
Attachment #8489689 - Attachment is obsolete: true
Attachment #8490879 - Flags: review+
And I just realized I didn't include mochitest-chrome in that try push. Sigh...
Looks like adding that null check fixed it!
Keywords: checkin-needed

Updated

5 years ago
Blocks: 1066313
https://hg.mozilla.org/mozilla-central/rev/f6c42abb5457
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Depends on: 1070107

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.