1067491 - Add allocation profiling to the memory actor

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Splitting this out from my work in bug 960671 for use in bug bug 1066361.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: memory-actors.patch

jryans, this is the same actor patch(es) you reviewed in bug 960671, but I just want to rubber stamp it again since it is in a new bug now. I split the toggling of recording into a start and stop method, as you asked.

This is a combined patch of the allocations changes, the force GC/CC changes, and a tiny method exposing Debugger.Memory.prototype.takeCensus over the RDP. It was getting too hard to keep everything separate, sorry.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cba18023568c

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8489689 [details] [diff] [review]
memory-actors.patch

Review of attachment 8489689 [details] [diff] [review]:
-----------------------------------------------------------------

Still seems good to me!

Comment 3

[Tim Nguyen :ntim]

Unless you're checking this in yourself, I think you should add a commit message to the patch.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/cc361e77343d

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48249937&tree=Fx-Team

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Hrm, I can't repro locally. Digging into the test logs...

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: memory-actors.patch

Ok just adding a check that the frame does exist in test_memory_allocations_01.html.

Let's see how this turns out: https://tbpl.mozilla.org/?tree=Try&rev=d00453950900

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

And I just realized I didn't include mochitest-chrome in that try push. Sigh...

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://tbpl.mozilla.org/?tree=Try&rev=86fccc2248f4

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Looks like adding that null check fixed it!

Comment 11

[Carsten Book [:Tomcat]]

landed as https://hg.mozilla.org/integration/fx-team/rev/f6c42abb5457

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6c42abb5457