[e10s] Veiw Selection Source does not work

VERIFIED FIXED in mozilla35

Status

()

Toolkit
View Source
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Alice0775 White, Assigned: billm)

Tracking

({regression})

Trunk
mozilla35
x86_64
Windows 7
regression
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(e10s+)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
It works on Firefox33.0b3(e10s)
However, it does not work on Aurora34.0a2(e10s) and Nightly35.a1(e10s)
(Reporter)

Comment 1

3 years ago
An error shows in Error Console

Error: TypeError: focusedWindow is null
Source File: chrome://browser/content/nsContextMenu.js
Line: 958
(Reporter)

Updated

3 years ago
Blocks: 1051017
(Assignee)

Updated

3 years ago
Assignee: nobody → wmccloskey
(Assignee)

Comment 2

3 years ago
Created attachment 8491140 [details] [diff] [review]
viewsource-fix
Attachment #8491140 - Flags: review?(mconley)
Comment on attachment 8491140 [details] [diff] [review]
viewsource-fix

Review of attachment 8491140 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine.

A quick glance, however, shows two other violations in nsContextMenu - do we have bugs on file for these? If not, would you mind filing them, or just plugging them right now before we forget?

http://hg.mozilla.org/mozilla-central/file/426497473505/browser/base/content/nsContextMenu.js#l1624
http://hg.mozilla.org/mozilla-central/file/426497473505/browser/base/content/nsContextMenu.js#l1632
Attachment #8491140 - Flags: review?(mconley) → review+
tracking-e10s: ? → +
(Assignee)

Comment 4

3 years ago
Created attachment 8491954 [details] [diff] [review]
context-menu-cpow-fixes
Attachment #8491954 - Flags: review?(mconley)
Comment on attachment 8491954 [details] [diff] [review]
context-menu-cpow-fixes

Review of attachment 8491954 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks billm!
Attachment #8491954 - Flags: review?(mconley) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d791f5094f
https://hg.mozilla.org/mozilla-central/rev/e3d791f5094f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify+
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0

Reproduced this issue on 2014-09-16 Nightly.
Verified this issue fixed on latest Nightly, build ID: 20141221030204.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.