Last Comment Bug 1067535 - [Tracking] Move as many job definition information into the mozharness in-tree configs as possible
: [Tracking] Move as many job definition information into the mozharness in-tre...
Status: RESOLVED FIXED
[easier-mozharness]
:
Product: Testing
Classification: Components
Component: General (show other bugs)
: unspecified
: x86_64 Linux
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on: 1100355 1109139 888118 981030 1035551 1040383 1064002 1067534 1070041
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-15 12:16 PDT by Andrew Halberstadt [:ahal]
Modified: 2015-03-31 14:45 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description User image Andrew Halberstadt [:ahal] 2014-09-15 12:16:48 PDT
Getting all the mozharness configs in-tree is kind of a big task, and is a massive pain to do. We have been moving them over slowly, piece by piece on an as-needed basis. This bug tracks all the other bugs that moved something from mozharness configs to in-tree configs.
Comment 1 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-09-19 09:03:51 PDT
Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1067534#c1
Comment 2 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-09-23 13:33:53 PDT
This will help with this: https://wiki.mozilla.org/User:Armenzg/Proposals/Mozharness_changes#Move_and_extend_information_used_from_in-tree_mozharness_configs
Comment 3 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-10-02 09:02:06 PDT
Here's a potential list of configs that are candidates to partially move into the tree (I have to further inspect them):
/home/armenzg/repos/mozharness/configs/android/androidarm.py
/home/armenzg/repos/mozharness/configs/android/androidx86.py
/home/armenzg/repos/mozharness/configs/android/android_panda_releng.py
/home/armenzg/repos/mozharness/configs/android/android_panda_talos_releng.py
/home/armenzg/repos/mozharness/configs/android/androidarm_dev.py
/home/armenzg/repos/mozharness/configs/b2g/releng-try.py
/home/armenzg/repos/mozharness/configs/b2g/releng-emulator.py
/home/armenzg/repos/mozharness/configs/b2g/releng-private-updates.py
/home/armenzg/repos/mozharness/configs/b2g/emulator_automation_config.py
/home/armenzg/repos/mozharness/configs/b2g/gaia_try.py
/home/armenzg/repos/mozharness/configs/b2g/releng-otoro-eng.py
/home/armenzg/repos/mozharness/configs/b2g/releng-fota-updates.py
/home/armenzg/repos/mozharness/configs/b2g/gaia_integration_config.py
/home/armenzg/repos/mozharness/configs/b2g/releng-otoro.py
/home/armenzg/repos/mozharness/configs/b2g/mulet_config.py
/home/armenzg/repos/mozharness/configs/b2g/desktop_automation_config.py
/home/armenzg/repos/mozharness/configs/b2g/releng-fota-eng.py
/home/armenzg/repos/mozharness/configs/b2g/taskcluster-emulator.py
/home/armenzg/repos/mozharness/configs/b2g/gaia_unit_production_config.py
/home/armenzg/repos/mozharness/configs/b2g/emulator_test_config.py
/home/armenzg/repos/mozharness/configs/b2g/generic_config.py
/home/armenzg/repos/mozharness/configs/b2g/gaia_unit_test_config.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_mac_configs/64_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_mac_configs/64_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_mac_configs/64_debug_and_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_asan.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/32_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_mulet.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_debug_and_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_linux_configs/64_asan_and_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_windows_configs/32_debug_and_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_windows_configs/32_debug.py
/home/armenzg/repos/mozharness/configs/builds/releng_sub_windows_configs/32_non_unified.py
/home/armenzg/repos/mozharness/configs/builds/releng_base_linux_32_builds.py
/home/armenzg/repos/mozharness/configs/builds/build_pool_specifics.py
/home/armenzg/repos/mozharness/configs/builds/releng_base_windows_32_builds.py
/home/armenzg/repos/mozharness/configs/builds/releng_base_mac_64_builds.py
/home/armenzg/repos/mozharness/configs/builds/branch_specifics.py
/home/armenzg/repos/mozharness/configs/builds/releng_base_linux_64_builds.py
/home/armenzg/repos/mozharness/configs/hazards/build_browser.py
/home/armenzg/repos/mozharness/configs/hazards/build_b2g.py
/home/armenzg/repos/mozharness/configs/hazards/common.py
/home/armenzg/repos/mozharness/configs/hazards/build_shell.py
/home/armenzg/repos/mozharness/configs/marionette/prod_config.py
/home/armenzg/repos/mozharness/configs/marionette/gaia_ui_test_prod_config.py
/home/armenzg/repos/mozharness/configs/marionette/automation_emulator_config.py
/home/armenzg/repos/mozharness/configs/marionette/gaia_ui_test_emu_config.py
/home/armenzg/repos/mozharness/configs/marionette/test_config.py
/home/armenzg/repos/mozharness/configs/marionette/windows_config.py
/home/armenzg/repos/mozharness/configs/talos/mac_config.py
/home/armenzg/repos/mozharness/configs/talos/windows_config.py
/home/armenzg/repos/mozharness/configs/talos/linux_config.py
/home/armenzg/repos/mozharness/configs/unittests/thunderbird_extra.py
/home/armenzg/repos/mozharness/configs/unittests/linux_unittest.py
/home/armenzg/repos/mozharness/configs/unittests/mac_unittest.py
/home/armenzg/repos/mozharness/configs/unittests/win_unittest.py
/home/armenzg/repos/mozharness/configs/web_platform_tests/prod_config.py
/home/armenzg/repos/mozharness/configs/web_platform_tests/prod_config_windows.py
/home/armenzg/repos/mozharness/configs/web_platform_tests/test_config.py
/home/armenzg/repos/mozharness/configs/web_platform_tests/test_config_windows.py

Here's the current list of configs in-tree:
-rw-r--r-- 1 armenzg armenzg 1920 Sep 24 10:41 android_arm_config.py
-rw-r--r-- 1 armenzg armenzg 3227 Sep  2 20:19 android_panda_config.py
-rw-r--r-- 1 armenzg armenzg 1921 Sep 24 10:41 android_x86_config.py
-rw-r--r-- 1 armenzg armenzg  943 Sep  2 20:19 b2g_desktop_config.py
-rw-r--r-- 1 armenzg armenzg 2976 Sep 24 10:41 b2g_emulator_config.py
-rw-r--r-- 1 armenzg armenzg 1597 Sep  2 20:19 linux_config.py
-rw-r--r-- 1 armenzg armenzg  295 Sep 29 15:57 linux_mulet_config.py
-rw-r--r-- 1 armenzg armenzg 1523 Sep  2 20:19 mac_config.py
-rw-r--r-- 1 armenzg armenzg 1814 Jul 15 10:44 marionette.py
-rw-r--r-- 1 armenzg armenzg  354 Sep  5 14:27 web_platform_tests_config.py
-rw-r--r-- 1 armenzg armenzg 1523 Sep  2 20:19 windows_config.py
Comment 4 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-10-29 08:32:09 PDT
I want to land bug 791924 first.
Comment 5 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-11-12 13:01:48 PST
After a first pass, what we have missing are:
* talos
* gaia

We will see after some proper digging.

I've put a summary in here:
https://wiki.mozilla.org/Auto-tools/Projects/Mozharness/Configs
Comment 6 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-11-12 14:10:30 PST
After further investigation it seems that we have already moved every suite definition from mozharness  to the tree. I updated the wiki table accordingly [1].

In the sense of moving mozharness configs we're pretty much done. Really.
In the sense of parameters passed for every at the very end is more of a hairy situation.
The parameters can be scattered on b-c and the actual mozharness scripts.

For instance if we compare gaia-unit and gaia-unit-oop, we can't modify that one is called with --browser-arg oop because it is defined in buildbot-configs [2] and not the tree.

In my opinion, we should close this bug (since it is done) and look at 2015 as to how we can tackle proper job definitions.
We have to overhaul buildbot-configs to leave all job definitions and scheduling to the tree or with a per-changeset configurations tool or move to TaskCluster.

On a separate note, ahal was asking that he wishes he could test various size chunking. I created a section talking about how to partially make it happen [3].

[1] https://wiki.mozilla.org/Auto-tools/Projects/Mozharness/Configs
[2]
http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla-tests/b2g_config.py#l1247
  1247                 'gaia-unit': {
  1248                     'extra_args': [
  1249                         '--cfg', 'b2g/gaia_unit_production_config.py',
  1250                     ],
  1251                 },
  1252                 'gaia-unit-oop': {
  1253                     'extra_args': [
  1254                         '--cfg', 'b2g/gaia_unit_production_config.py',
  1255                         '--browser-arg', '-oop',
  1256                     ],
  1257                 },
[3] https://wiki.mozilla.org/User:Armenzg/Automation_tricks#How_to_test_different_chunk_ratios
Comment 7 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-11-13 06:48:04 PST
There is also bug 1064002, bug 1040383 and bug 1070041 which moves more things into the in-tree configs (expanding what we read from the in-tree-configs).
Comment 8 User image Andrew Halberstadt [:ahal] 2014-11-13 07:59:46 PST
Cool yeah. I had intended this to be a tracking bug to keep track of all the smaller bugs like those.
Comment 9 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-11-26 08:41:00 PST
We don't depend on bug 791924 but it is easier to test on try with it.
Comment 10 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-12-18 13:31:15 PST
ahal, this bug was filed as to track moving testing configs into the tree, however, we determined that test job definitions were already in the tree.

We have only further moved information into those existing configs.

Should we close this bug? or rephrase what it tracks?
Comment 11 User image Andrew Halberstadt [:ahal] 2014-12-18 13:35:18 PST
I think moving that information into existing in-tree configs is in line with the purpose of this bug. I'm not sure if there's still more information you plan on moving or not. I'm fine with closing this either way, but up to you!
Comment 12 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2014-12-18 15:44:06 PST
I will simply re-word it to capture exactly that. Thanks ahal.
Comment 13 User image Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) 2015-03-31 14:45:00 PDT
Mass comment: With mozharness moving into the tree [1] and pinning of mozharness we can assume that anything left (if any) in this bug will be easily taken care of.

[1] http://jordan-lund.ghost.io/mozharness-steps-into-the-forest

Note You need to log in before you can comment on or make changes to this bug.