release runner breaks if there isn't an existing buildbot-configs check out

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8489611 [details] [diff] [review]
fix order of operations

Just noticed this in a staging release. Turns out that sendMailRD requires the release config to be on disk, but this code runs before any repos are cloned.

I tested this patch once on dev-master
Attachment #8489611 - Flags: review?(rail)
Attachment #8489611 - Flags: review?(rail) → review+
Does this fix bug 1063442 too ?
(Assignee)

Comment 2

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #1)
> Does this fix bug 1063442 too ?

I don't think it fixes the "don't spam release drivers" part, but I'm not totally sure...
(Assignee)

Comment 3

3 years ago
Comment on attachment 8489611 [details] [diff] [review]
fix order of operations

Landed, updated bm81, and restarted release runner to pick it up.
Attachment #8489611 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(In reply to Ben Hearsum [:bhearsum] from comment #2)
> (In reply to Nick Thomas [:nthomas] from comment #1)
> > Does this fix bug 1063442 too ?
> 
> I don't think it fixes the "don't spam release drivers" part, but I'm not
> totally sure...

Agreed - it solves the underlying problem (the sendMailRD function requires that the config file "cfgFile" can be read and exec'd - https://docs.python.org/2/library/functions.html#execfile) - but in the case of a failure for some other reason in the execution of buildfarm/release/release-runner.py from buildfarm/release/release-runner.sh, emails could still be potentially sent every minute to release drivers.
You need to log in before you can comment on or make changes to this bug.