python errors in mobile_l10n.py

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jlund, Assigned: kmoir)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This was discovered by running './unit.sh':

### Running pyflakes
scripts/mobile_l10n.py:40: 'VCSMixin' imported but unused
scripts/mobile_l10n.py:41: 'BaseScript' imported but unused
scripts/mobile_l10n.py:276: local variable 'abs_work_dir' is assigned to but never used
scripts/mobile_l10n.py:556: local variable 'c' is assigned to but never used
scripts/mobile_l10n.py:566: undefined name 'fatal'

the last one would cause a python error (it's missing self). I think it would only be reached from a negative result so we probably haven't seen it get hit yet.
(Assignee)

Updated

3 years ago
Assignee: nobody → kmoir
(Assignee)

Comment 1

3 years ago
Created attachment 8489741 [details] [diff] [review]
bug1067597.patch
Attachment #8489741 - Flags: review?(jlund)
Comment on attachment 8489741 [details] [diff] [review]
bug1067597.patch

Review of attachment 8489741 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :)
Attachment #8489741 - Flags: review?(jlund) → review+
(Assignee)

Updated

3 years ago
Attachment #8489741 - Flags: checked-in+
Merged to prod (2014-09-16 08:21 PT)
(Assignee)

Comment 4

3 years ago
Should have closed this a while ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.