The first time you type in URLbar, you get "JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue"

RESOLVED FIXED in mozilla35

Status

()

Toolkit
Places
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: mak)

Tracking

Trunk
mozilla35
x86_64
Linux
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
STR:
 1. Start a m-c debug build from the terminal, with a fresh profile (empty folder).
 2. Ctrl+L to focus URLbar. Type the character "a"
 3. After the autocomplete dropdown appears, look at your terminal.

ACTUAL RESULTS:
{
JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue
}


Setting as blocking bug 995091, since this is at least tied to that feature. (though there may be a better bug for this to block or depend on; feel free to adjust)
(Reporter)

Updated

3 years ago
Flags: needinfo?(mak77)
(Reporter)

Comment 1

3 years ago
I'm not sure if I should trust the line number, but if I should, then line 760 from that file (loaded using the URL from my terminal)  refers to the last line of code here (I'm providing a bit of pruned before-code for context):
>  _matchSearchEngineUrl: function* () {
[...]
>    let match = yield PlacesSearchAutocompleteProvider.findMatchByToken(
>                                                           this._searchString);
[...]
>      // In any case, we should never arrive here with a value that doesn't
>      // match the search string.  If this happens there is some case we
>      // are not handling properly yet.
>      if (!value.startsWith(this._originalSearchString)) {
>        Components.utils.reportError(`Trying to inline complete in-the-middle
>                                      ${this._originalSearchString} to ${value}`);
(Line 760 is this final line here:     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

That line was added recently in bug 1059846.
Blocks: 1059846
(Assignee)

Comment 2

3 years ago
this is a very strange error, match.finalCompleteValue can be undefined but we are just passing it out... and I can't see how stuff at line 760 is involved, it should even be executed.

I guess it's easier to try and see what I figure out.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(mak77)
(Assignee)

Comment 3

3 years ago
Created attachment 8497110 [details] [diff] [review]
patch v1
Attachment #8497110 - Flags: review?(bmcbride)
(Assignee)

Updated

3 years ago
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Attachment #8497110 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/af3a8b7f7cb2
Target Milestone: --- → mozilla35

Updated

3 years ago
Iteration: --- → 35.3
https://hg.mozilla.org/mozilla-central/rev/af3a8b7f7cb2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.