1067602 - The first time you type in URLbar, you get "JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue"

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start a m-c debug build from the terminal, with a fresh profile (empty folder).
 2. Ctrl+L to focus URLbar. Type the character "a"
 3. After the autocomplete dropdown appears, look at your terminal.

ACTUAL RESULTS:
{
JavaScript strict warning: file:///$OBJDIR/dist/bin/components/UnifiedComplete.js, line 760: ReferenceError: reference to undefined property match.finalCompleteValue
}


Setting as blocking bug 995091, since this is at least tied to that feature. (though there may be a better bug for this to block or depend on; feel free to adjust)

Comment 1

[Daniel Holbert [:dholbert]]

I'm not sure if I should trust the line number, but if I should, then line 760 from that file (loaded using the URL from my terminal)  refers to the last line of code here (I'm providing a bit of pruned before-code for context):
>  _matchSearchEngineUrl: function* () {
[...]
>    let match = yield PlacesSearchAutocompleteProvider.findMatchByToken(
>                                                           this._searchString);
[...]
>      // In any case, we should never arrive here with a value that doesn't
>      // match the search string.  If this happens there is some case we
>      // are not handling properly yet.
>      if (!value.startsWith(this._originalSearchString)) {
>        Components.utils.reportError(`Trying to inline complete in-the-middle
>                                      ${this._originalSearchString} to ${value}`);
(Line 760 is this final line here:     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

That line was added recently in bug 1059846.

Comment 2

[Marco Bonardo [:mak]]

this is a very strange error, match.finalCompleteValue can be undefined but we are just passing it out... and I can't see how stuff at line 760 is involved, it should even be executed.

I guess it's easier to try and see what I figure out.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/af3a8b7f7cb2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af3a8b7f7cb2