1067639 - Trying to provide custom keyboard settings via a SIM customization with the provided SIM fails to set the settings correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Jason Smith [:jsmith]]

Build Information
Device: Flame
Gaia      e731a63484c532168f4de6dc1eeb4c6612ad73a9
Gecko     7546fedad918
BuildID   20140915000203
Version   34.0

Build Setup

1. Flash the 9/15 build
2. Pull Gaia locally with git & switch to the 2.1 branch
3. In the gaia directory, run MOZILLA_OFFICIAL=1 GAIA_DISTRIBUTION_DIR=customization make production

STR

1. Complete the FTE & open the settings --> keyboards --> built-in keyboard

Expected

Settings should be set to the following:

{"vibration":true,"autocorrect":false,"clicksound":true,"wordsuggestion":false}

Actual

Settings end up being set to the following:

{"vibration":true,"autocorrect":true,"clicksound":false,"wordsuggestion":true}

Comment 1

[Jason Smith [:jsmith]]

QA Wanted to see if this works on 2.0 or not.

Comment 2

[Jason Smith [:jsmith]]

Forgot one precondition that was used in testing this - I had a T-Mobile US SIM included on the phone. I confirmed that other customizations (e.g. preloaded bookmarks) did work, so I know the SIM customization was done on the phone.

Comment 3

[Jason Smith [:jsmith]]

George - This customization feature is supposed to work, right? I used your customization in the Gaia repository to test this, but I can't get it to work with my T-Mobile US SIM.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

As I know, we have a operatorvariant app that will override settings from customization in runtime.
https://github.com/mozilla-b2g/gaia/blob/master/build/test/integration/distribution.test.js#L86-L105

Hi Albert,
please correct me if I am wrong.

Comment 5

[Albert [:albert]]

(In reply to George Duan [:gduan] [:喬智] from comment #4)
> As I know, we have a operatorvariant app that will override settings from
> customization in runtime.
> https://github.com/mozilla-b2g/gaia/blob/master/build/test/integration/
> distribution.test.js#L86-L105
> 
> Hi Albert,
> please correct me if I am wrong.

Hi,

Yes, that's correct, feature is implemented. The problem is the wrong format of customization/mobizilla/mobizilla_keyboard.json file. See how the file should be at https://github.com/telefonicaid/firefoxos-gaia-testsbuild/blob/master/resources/keyboard_movistar.json

Comment 6

[Albert [:albert]]

Attachment: Patch

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8489860 [details] [review]
Patch

r=yurenju, albert, could you file another bug for throwing error if keys of properties does not contain "keyboard."?

Comment 8

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/a0201878d07d31ce620782f8a3efa0e60a4ad159