Closed Bug 1067643 Opened 5 years ago Closed 5 years ago

Browser console reports: "TypeError: variable request redeclares argument" from dbg-client.jsm:793

Categories

(DevTools :: Debugger, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: dholbert, Assigned: fitzgen)

References

Details

Attachments

(1 file)

Not sure what I did exactly to trigger it, but I noticed this in my Browser Console:
{
TypeError: variable request redeclares argument         dbg-client.jsm:793
}

This is from this code:
> 776   startBulkRequest: function(request) {
[...]
> 793     let request = new Request(request);
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/client/dbg-client.jsm?rev=2498263e8cf7#793

Elsewhere in this file, we name the argument "aRequest". We should probably do that here, too -- that would resolve this naming collision.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8489744 - Flags: review?(past)
aArgs aNeed aTo aDie
Comment on attachment 8489744 [details] [diff] [review]
bug-1067643.patch

Review of attachment 8489744 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> aArgs aNeed aTo aDie

I'm bringing my shotgun.
Attachment #8489744 - Flags: review?(past) → review+
This should be ready to land, no?
This doesn't apply anymore, but that's good because it looks like shu already got to this and fixed it.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Summary: Noticed in Browser Console: "TypeError: variable request redeclares argument" from dbg-client.jsm:793 → Browser console reports: "TypeError: variable request redeclares argument" from dbg-client.jsm:793
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.