Closed Bug 1067647 Opened 10 years ago Closed 10 years ago

Attach pull requests to bugs

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

KevinGrandon:master PR#2
49 bytes, text/x-github-pull-request
garndt
: review+
Details | Review 
      No description provided.
Whiteboard: [systemsfe]
Comment on attachment 8489710 [details] [review]
KevinGrandon:master PR#2

James, Greg - Before taking this further, could you guys give this a review? Thanks!
Attachment #8489710 - Flags: review?(jlal)
Attachment #8489710 - Flags: review?(garndt)
Sorry about the delay on this.  Reviewing now and should get back to you soon on it.
Comment on attachment 8489710 [details] [review]
KevinGrandon:master PR#2

I'm good with this as long as we address when a merge fails.  Comments in GH.
Attachment #8489710 - Flags: review?(garndt) → review+
Comment on attachment 8489710 [details] [review]
KevinGrandon:master PR#2

Thanks. I will address and get this landed.
Attachment #8489710 - Flags: review?(jlal)
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
Merged to master: ea7955e04810d53908146ec92804bae94666f462
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
Blocks: gaia-autoland
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: