1067807 - React to the removal of non-Encoding Standard DOS encodings

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 997124 removed IBM8xy encodings other than IBM866 (Cyrillic). (CP874, Thai, has the preferred name windows-874 and remains.)

Mailnews should either import these to comm-central or remove the comm-central references to these encodings:
https://mxr.mozilla.org/comm-central/search?string=IBM850

Comment 1

[Henri Sivonen (:hsivonen)]

https://groups.google.com/forum/#!topic/mozilla.dev.apps.thunderbird/2P5kCJJS_WI

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1067807_react_ibm_dos.patch

This patch removes them...
CVS blame says they were added in year 2000, but there's no bug number.

Comment 3

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8526219 [details] [diff] [review]
bug1067807_react_ibm_dos.patch

Review of attachment 8526219 [details] [diff] [review]:
-----------------------------------------------------------------

I was given some data from Fastmail about some charset statistics on their server. IBM-852 and cp-850 showed up on that, but on the same threshold as outright malformed charsets (e.g., utf-6). I don't think we need to support it, but we ought to keep an eye out for complaints here.

::: mail/locales/en-US/chrome/messenger/charsetTitles.properties
@@ -59,5 @@
>  x-viet-tcvn5712.title = Vietnamese (TCVN)
>  viscii.title = Vietnamese (VISCII)
>  x-viet-vps.title = Vietnamese (VPS)
>  windows-874.title = Thai (Windows-874)
> -ibm874.title = Thai (IBM-874)

Lol, what? We had an entry for ibm874, but normalized ibm874 to windows-874?

Well, I'm glad sense is slowly being brought to this mess known as charsets.

::: mailnews/intl/charsetalias.properties
@@ -74,5 @@
>  iso8859-1=ISO-8859-1
>  iso_8859-1:1987=ISO-8859-1
>  iso-ir-100=ISO-8859-1
>  l1=ISO-8859-1
> -ibm819=ISO-8859-1

This one sticks around in the encoding spec, but it gets normalized to windows-1252 instead. Shouldn't have any effect though, so it should be safe to delete this.

@@ -122,3 @@
>  
>  # Aliases for windows-874 
>  ibm874=windows-874

You may want to drop this line as well?

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/a9651712f4e7 -> FIXED