Closed Bug 1067812 Opened 5 years ago Closed 2 years ago
Add date selectors to the review history API and default to the last 30 days
The review history page seems to only be showing the last 6 months of reviews - however the page doesn't indicate this. I think we should either: 1) Have a date range picker so it's both clear what date range is set, and it can then be adjusted 2) Have a heading/description that says "Review history for last 6 months" or similar.
The only option is 2, as we have only been tracking flag history for about 6 months.
Ah I thought it was dynamically generated.
Yeah we should add a date picker at some point. Not critical for now.
Priority: -- → P2
The review history page is now quite unwieldy, since it shows all reviews ever performed since mid 2014. I think it should either: 1) Only show the last N months (where N is perhaps 3) with no option to override 2) Have a date picker to allow custom ranges, but default to something sensible (like the last 1 month)
Summary: Review history page only shows recent review history but doesn't indicate timeframe → Add a time picker to the review history page
Summary: Add a time picker to the review history page → Add a date picker to the review history page
Maybe you could take a look at this one?
Assignee: dylan → nobody
As the front-end code is YUI3, I have a strict policy of not furthering development on that. Thus I have refocused this to just fixing the API.
Summary: Add a date picker to the review history page → Add date selectors to the review history API
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
The commit that landed didn't get auto-commented to the bug for some reason: https://github.com/mozilla-bteam/bmo/commit/b1abfe7caca072a36c312d6961ff9fbbfe306933 It made the API accept a date range, and defaulted the range to the last 30 days if no dates are provided. Since the UI doesn't pass any dates, it now displays the last 30 days only (which is much faster), updating summary accordinly. Many thanks!
Summary: Add date selectors to the review history API → Add date selectors to the review history API and default to the last 30 days
You need to log in before you can comment on or make changes to this bug.