1067861 - Switching between unclassified failures is now slower/more jerky on treeherder-dev

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Compare treeherder on production with treeherder-dev.
On each, press the 'j' key to cycle through the unclassified jobs.

On tbpl-dev the behaviour seems regressed:
* The job details panel changes size, but in a really jerky way
* The time taken for the failure lines to appear seems longer
* Also, the resizing panel, whilst helpful in some ways since it allows more content to be seen it quite distracting, since the panel bounces around and there isn't a consistent place to glance down at when scanning the failures/job details quickly (aiming to classify a failure every second or two to meet TBPL parity).

Comment 1

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #0)
> On tbpl-dev the behaviour seems regressed:

treeherder-dev even :-)

Comment 2

[Mauro Doglio [:mdoglio]]

(In reply to Ed Morley [:edmorley] from comment #0)
> Compare treeherder on production with treeherder-dev.
> On each, press the 'j' key to cycle through the unclassified jobs.
> 
> On tbpl-dev the behaviour seems regressed:
> * The job details panel changes size, but in a really jerky way
The content of that panel is coming from 3 different ajax calls, I cant try to refresh the content when all of them are completed.

> * The time taken for the failure lines to appear seems longer
I guess the requested change here is to not display the "failure summary is empty" message while donwloading the bug suggestions

> * Also, the resizing panel, whilst helpful in some ways since it allows more
> content to be seen it quite distracting, since the panel bounces around and
> there isn't a consistent place to glance down at when scanning the
> failures/job details quickly (aiming to classify a failure every second or
> two to meet TBPL parity).
:edmorley this is not clear to me, can you please detail the request more?

Comment 3

[Ed Morley [:emorley]]

(In reply to Mauro Doglio [:mdoglio] from comment #2)
> > * The time taken for the failure lines to appear seems longer
> I guess the requested change here is to not display the "failure summary is
> empty" message while donwloading the bug suggestions

No that's not what I mean - that issue is bug 1067854.
I'm meaning the actual speed taken to load several issue in turn, and let the failure lines appear.

> > * Also, the resizing panel, whilst helpful in some ways since it allows more
> > content to be seen it quite distracting, since the panel bounces around and
> > there isn't a consistent place to glance down at when scanning the
> > failures/job details quickly (aiming to classify a failure every second or
> > two to meet TBPL parity).
> :edmorley this is not clear to me, can you please detail the request more?

I think we cleared this up on IRC - let me know if not :-)

Comment 4

[Mauro Doglio [:mdoglio]]

Attachment: PR 187 on treeherder-ui

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8490167 [details] [review]
PR 187 on treeherder-ui

When clicking between the two jobs shown on:
http://localhost:8000/app/index.html#/jobs?repo=mozilla-central&searchQuery=b2g_mozilla-central_emulator-debug_dep

It takes two clicks on the same job before all of the attributes update.

eg:
1) Open the link
2) Click on the red job -> notice how the job result colour is missing from the bottom left panel
3) Click on the green job -> notice how the job result colour is wrong, and the raw log link is pointing still to the failing job's log.

Comment 6

[Mauro Doglio [:mdoglio]]

Good catch :edmorley, I'll fix it.

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8490167 [details] [review]
PR 187 on treeherder-ui

I saw a typo in a comment.  But other than that, good to merge.

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8490167 [details] [review]
PR 187 on treeherder-ui

Look great - thank you :-)

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/452bdaa01b022b0aa045bc53e9011f0ed646095f
Bug 1067861 - optimize data loading in the bottom panel

https://github.com/mozilla/treeherder-ui/commit/3cccf218f83bdc92398cd26206a94b2e7f3946a7
Merge pull request #187 from mozilla/bug-1067861-optimize-data-loading-bottom-panel

Bug 1067861 - optimize data loading in the bottom panel

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c9b137a86ae5046d5f28d7ab4b215daf81f98cb5
Bug 1067861 - optimize data loading in the bottom panel

https://github.com/mozilla/treeherder/commit/80b35dae06daaeec0a11cf697c5c2f5219361579
Merge pull request #187 from mozilla/bug-1067861-optimize-data-loading-bottom-panel

Bug 1067861 - optimize data loading in the bottom panel