Async Places Transactions: when copying an item, do not copy "special" annotations

RESOLVED FIXED in mozilla35

Status

()

Toolkit
Places
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

unspecified
mozilla35
x86
Mac OS X
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 1058566 and the original bug for the legacy implementation, bug 629620.
Blocks: 984903
Points: --- → 2

Updated

3 years ago
Flags: qe-verify?
Flags: firefox-backlog+

Updated

3 years ago
Status: NEW → ASSIGNED
Iteration: --- → 35.2

Updated

3 years ago
Flags: qe-verify? → qe-verify-
Created attachment 8492229 [details] [diff] [review]
patch.diff
Attachment #8492229 - Flags: review?(mak77)
Comment on attachment 8492229 [details] [diff] [review]
patch.diff

Review of attachment 8492229 [details] [diff] [review]:
-----------------------------------------------------------------

Please just verify what we do today regarding excluded annotations and aRestoring.

::: toolkit/components/places/PlacesTransactions.jsm
@@ +740,2 @@
>  // Update the documentation at the top of this module if you add or
>  // remove properties.

looks like you are not reading your own comments :)

@@ +819,5 @@
>   *        Whether or not the items are restored.  Only in restore mode, are
>   *        the guid, dateAdded and lastModified properties honored.
> + * @param [optional] aExcludingAnnotations
> + *        Array of annotations names set on any item in aBookmarksTree to
> + *        ignore. This is ignored if aRestoring is set.

I don't like the phrase, it's quite unclear:
"Array of annotations names set on any item in aBookmarksTree to ignore."

I'm not sure if it's correct to ignore it on restore, what do we do today?
Attachment #8492229 - Flags: review?(mak77) → review+
That's the current behavior actually (see PlacesRemoveItemTransaction), which makes sense of course (otherwise it's not a true "undo").
https://hg.mozilla.org/integration/fx-team/rev/dca3955efe70
https://hg.mozilla.org/mozilla-central/rev/dca3955efe70
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.