Closed Bug 1067995 Opened 10 years ago Closed 10 years ago

[Loop] Loop app can't receive an incoming call when the user is on the feedback window

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbarone976, Assigned: borjasalguero)

References

Details

(Whiteboard: [mobile app][blocking][tef-triage][patch available])

Attachments

(1 file)

STR
1. Make a Loop call from device A to device B
2. Device A ends the call
3. On Device B, the feedback window is shown. Don't close this window
4. Try to perform a loop call to device B

ACTUAL RESULT
The incoming call screen is not shown on Device B

EXPECTED RESULT
As discussed with UX, the feedback window should be closed and the the new call should be shown to the user
Assignee: nobody → borja.bugzilla
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Status: NEW → ASSIGNED
Severity: normal → major
Whiteboard: [mobile app] → [mobile app][blocking][tef-triage]
Attached file Pull Request
Attachment #8496033 - Flags: review?(josea.olivera)
Whiteboard: [mobile app][blocking][tef-triage] → [mobile app][blocking][tef-triage][patch available]
Comment on attachment 8496033 [details] [review]
Pull Request

LGTM. r=me

Please, drop the debug info you added and have a look at a few comments I left on the PR.
Attachment #8496033 - Flags: review?(josea.olivera) → review+
Comment on attachment 8496033 [details] [review]
Pull Request

Due to there were a lot of changes needed when rebasing, I'll ask to review again.
Attachment #8496033 - Flags: review+ → review?(josea.olivera)
(In reply to Borja Salguero [:borjasalguero] from comment #3)
> Comment on attachment 8496033 [details] [review]
> Pull Request
> 
> Due to there were a lot of changes needed when rebasing, I'll ask to review
> again.

Thanks for requesting a new review at me again. The latest changes from other bugs force us to review this again before landing the patch here. Left a few comments and needs on the pull request. Have a look and lets pair up for the last pass.
Comment on attachment 8496033 [details] [review]
Pull Request

LGTM. r=me

Thanks for taking care of it!, land at will please!
Attachment #8496033 - Flags: review?(josea.olivera) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified on flame, Gecko-7107b06.Gaia-c1f6089, 
Lopp version: b513867,
Ram: 512M,
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: