1068030 - Time format is not set to a proper default locale value

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[:gerard-majax]

On current master.

STR:
 0. Flash a new device
 1. Go through FTU
 2. Configure in french locale

Expected:
 Time format should be 24h

Actual:
 Time format is defaulting to 12h

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I guess we regressed bug 1055424?

Comment 2

[Julien Wajsberg [:julienw]]

Bug 1055424 is different as it handles upgrading. Here Alexandre is talking about the FTU application. So maybe this case was simply overlooked.

QA: can you please check on the 2.1 branch?

Asking a v2.1 blocking status because the issue likely happens on v2.1 too.

Comment 3

[Cody Roesch [:croesch]]

This bug repro's on Flame KK builds: Flame 2.2, Flame 2.1, OpenC 2.2

Actual Results: Setting up in French locale during FTU sets the clock as 12h instead of 24hr.

Repro Rate: 3/3

Environmental Variables:
Device: Flame Master
BuildID: 20140915201445
Gaia: e2d70bee03b5380ac327a145e5d694fb2443f018
Gecko: 0e581e529fd6
Version: 35.0a1 (Master) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1
BuildID: 20140916065549
Gaia: 5753b75bdd644f0e58536becd702779364340a4b
Gecko: 333807127cd1
Version: 34.0a2
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Open_C Master
BuildID: 20140915201445
Gaia: e2d70bee03b5380ac327a145e5d694fb2443f018
Gecko: 0e581e529fd6
Version: 35.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.0, Flame 1.4 Base

Actual Result: Setting up in French locale during FTU sets the clock as 24h correctly.

Repro Rate: 0/2 attempts

Environmental Variables:
Device: Flame 2.0
BuildID: 20140916051646
Gaia: 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 0ef9688da1b6
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140814202332
Gaia: 129211661489feb60bbd6772a44081d23b374f17
Gecko: 
Version: 30.0 (1.4)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 4

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working

Device: Flame 2.1
Build ID: 20140821011815
Gaia: fd879952bd9d22afba5c2c78ffe3c62c17ea5be8
Gecko: 9f041df4ba9b
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken

Device: Flame 2.1
Build ID: 20140821015814
Gaia: 579a8714d1c5b382bdd10383477d1221c04dc288
Gecko: 10cff3eb87f3
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: fd879952bd9d22afba5c2c78ffe3c62c17ea5be8
Gecko: 10cff3eb87f3

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 579a8714d1c5b382bdd10383477d1221c04dc288
Gecko: 9f041df4ba9b

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/fd879952bd9d22afba5c2c78ffe3c62c17ea5be8...579a8714d1c5b382bdd10383477d1221c04dc288

Probable Cause: 

Bug 1054135 - [B2G][System] support 24 hour time format for Time picker

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1054135 - can you take a look Fred?

Comment 6

[[e-mail]]

Thanks for finding it. Will check it soon.

Comment 7

[Gregor Wagner [:gwagner]]

Broken feature.

Comment 8

[[e-mail]]

Found current implement get the locale string from previous select language.
We need change language first then get the proper time format later.

Comment 9

[[e-mail]]

Attachment: pull request redirect to github

The previous implementation write the hour12 value at wrong state.
This patch listen to localized event to set proper timeformat.

Please kindly review it, thanks.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8492821 [details] [review]
pull request redirect to github

Redirecting to Sam, I'm  a bit overloaded and sure he can find someone to do the proper review.

Comment 11

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8492821 [details] [review]
pull request redirect to github

Looks good to me, I tried setting French language, after a few steps into the FTU the time showed up and was correctly 24h format. I backed up and set English language, and (after a few steps) the format went back to 12h. 

Bonus points for trimming the xfail list, thanks!

Comment 12

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/e9171944a82549dfb6082dc03480687a6c2aa2a1

thanks!

Comment 13

[[e-mail]]

Comment on attachment 8492821 [details] [review]
pull request redirect to github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1053024 
[User impact] if declined: incorrect timezone setting for french and other country with 12h by default
[Testing completed]: TBPL passed
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/8061ab487d42cbc49b329fd68b9ca90e0fe477e6

Comment 15

[Seth Miko [:SMiko]]

Verified fixed on Flame 2.2 (319mb/full flash) and Flame 2.1 (319mb/full flash) 

Actual result: Time format is set to 24hr when setting the language to French in the FTU.

Device: Flame 2.2
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0