Closed Bug 1068051 Opened 5 years ago Closed 5 years ago

Low res drawables for devices used in the synced tabs panel

Categories

(Firefox for Android :: General, defect)

35 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
fennec 35+ ---

People

(Reporter: aaronmt, Assigned: nalexander)

References

Details

Attachments

(3 files)

Attached image screenshot.png
See screenshot.

--
Nightly (09/16)
Samsung Galaxy S5 (Android 4.4.4)
tracking-fennec: --- → ?
Yep, known issue.  I'd actually like to expand the set of "device types" to {desktop, laptop, tablet, phone} or similar; but I'm not sure how accurate we can make this determination.  I think we could arrange for tablet/phone on Android pretty accurately.  rnewman?  Technically older clients would display incorrect icons for a while, but whatever.

antlam: can we get updated visuals for these icons?
Flags: needinfo?(rnewman)
Flags: needinfo?(alam)
(In reply to Nick Alexander :nalexander from comment #1)

> rnewman?  Technically older clients would
> display incorrect icons for a while, but whatever.

We could add an additional 'type' field to the client record, but we would have to expect it to be missing.

We had planned to significantly improve the client schema in Sync 2.0, but alas.

Without extending the data format, we're pretty much unable to do anything other than desktop (laptop) vs mobile.
Flags: needinfo?(rnewman)
(In reply to Richard Newman [:rnewman] from comment #2)
> Without extending the data format, we're pretty much unable to do anything
> other than desktop (laptop) vs mobile.

That's alright, I can get a handheld and a laptop graphic. Will attach in a bit once I finalize these designs
(In reply to Richard Newman [:rnewman] from comment #2)
> (In reply to Nick Alexander :nalexander from comment #1)
> 
> > rnewman?  Technically older clients would
> > display incorrect icons for a while, but whatever.
> 
> We could add an additional 'type' field to the client record, but we would
> have to expect it to be missing.
> 
> Without extending the data format, we're pretty much unable to do anything
> other than desktop (laptop) vs mobile.

Yep, that's what I was thinking.  We could increase the set of recognized options of our existing field (type) [1], or we could add an extra subfield.  We already have default logic everywhere -- I say we expand it out.  Recognize "desktop", "mobile", "laptop", "tablet" and fallback like we already do.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/sync/repositories/domain/ClientRecord.java#39
Attached file panel_sync_assets.zip
Attaching assets here too.
Flags: needinfo?(alam)
tracking-fennec: ? → 35+
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c1aee3301e77
https://hg.mozilla.org/mozilla-central/rev/eacc36bb5d25
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Attached patch low-res-fix v0.1Splinter Review
Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Poorer visuals with respect to the Sharing Overlay
[Describe test coverage new/current, TBPL]: Working fine on Fx36 and Fx35
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8515466 - Flags: review+
Attachment #8515466 - Flags: approval-mozilla-beta?
Comment on attachment 8515466 [details] [diff] [review]
low-res-fix v0.1

Beta+
Attachment #8515466 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.