1068098 - [Contacts] Deleting a comment on a contact causes all other comments to disappear on edit screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Robert Mead [:RobertM]]

Attachment: Flame2.1logcat.txt

Description:
While editing a contact in the 'Contacts' app, if the contact had multiple comments saved and you try and delete one, all the comments disappear while you're still in the edit page.
   
Prereq: Have a contact added with at least 2 comments added.

Repro Steps:
1) Update a Flame device to BuildID: 20140915000203
2) Tap 'Contacts' app.
3) Scroll and tap on the contact with the comments.
4) Tap the edit icon in the upper right corner.
5) Scroll down to the comment boxes and tap the red circle with the 'X' next to one of the comments.
  
Actual:
All the comment boxes disappear.
  
Expected: 
The comment box should disappear.
  
Flame 2.1 (319mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: Even though the other comments visually disappear on the edit page, when you update and are brought back to the contact page, the non-deleted comments will be there.
  
Repro frequency: 100%
See attached: logcat, video - http://youtu.be/iAFI76xwwKk

Comment 1

[Robert Mead [:RobertM]]

This issue occurs on Flame 2.2 (319mb), Flame 2.1 (512mb), Open_C 2.2, and Open_C 2.1

When editing a contact with multiple comments, if you delete a comment via the Red circle with the white 'X', the rest of the comments disappear too.


Flame 2.2 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140915040203
Gaia: 855be6ade407c26e0596e7306a44deebc3f60933
Gecko: f27ff178807d
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 (512 mb)

Environmental Variables:
Device: Flame 2.1
Build ID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version:34.0a2 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open_C 2.2

Environmental Variables:
Device: Open_C Master
BuildID: 20140915040203
Gaia: 855be6ade407c26e0596e7306a44deebc3f60933
Gecko: f27ff178807d
Version: 35.0a1 (Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open_C 2.1

Environmental Variables:
Device: Open_C 2.1
BuildID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version: 34.0a2 (2.1)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0



This issue does not occur on Flame 2.0 (319mb), Flame 2.0[KK] (319mb), and Open_C 2.0 because after version 2.0 the 'Edit Contacts' page received a new UX


Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140915000202
Gaia:7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 13e04ab68621
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile;rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.0 KitKat Base (319mb)

Enviromental Variables:
Device: Flame 2.0
BuildID: 20140914183002
Gaia: 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 13e04ab68621
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Enviromental Variables:
Device: Open_C 2.0
BuildID: 20140915000202
Gaia: 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 13e04ab68621
Version: 32.0 (2.0)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:
We have data loss here, nominating for 2.1

Comment 3

[Maria Angeles Oteo (:oteo)]

triage: blocking bug, data lost.

Comment 4

[Jose Manuel Cantera]

This is a blocker and we need to solve it ASAP. I'm stealing it as I know better the code and can fix it more rapidly

sorry Jorge

best

Comment 5

[Jorge Prudencio [:jorgep]]

No problem, I propose one solution on the next link. It can help you ;-)

https://github.com/jpruden92/gaia/compare/bug1068098-contacts

Comment 6

[Jose Manuel Cantera]

(In reply to Jorge Prudencio [:jorgep] from comment #5)
> No problem, I propose one solution on the next link. It can help you ;-)
> 
> https://github.com/jpruden92/gaia/compare/bug1068098-contacts

thanks for the attempt but there is a more generic and elegant solution as you will see in my PR :)

Comment 7

[Jose Manuel Cantera]

Attachment: 24136.html

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8490667 [details]
24136.html

Working perfectly.

Good unit test as well, thanks!

Comment 9

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/980f5e0c6dcf18495b88165ab516e944f2bdaa59

Comment 10

[Jose Manuel Cantera]

Comment on attachment 8490667 [details]
24136.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Contacts Visual Refresh
[User impact] if declined: High, Loss of information
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk patch
[String changes made]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/36a5a5cd4ea58c9f64778547572a910a2b91a042

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2:

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The only deleted comment box disappears. All remaining comment boxes stay on the screen.
---------------------------------------
This issue still occurs on Flame 2.1:

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Failed verification on 2.1. Filed a new bug 1081748.

Comment 14

[Jose Manuel Cantera]

Ryan, 

This bug has not been properly uplifted to v2.1. Please check

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Sorry, I copy/pasted the wrong URL in comment 11. It *was* uplifted on the 22nd, though.
v2.1: https://github.com/mozilla-b2g/gaia/commit/9b039a1bd37950e64ad827bb3b4208e367ed4464

Which I guess means it's back to you, Jose, to debug what's wrong.

Comment 16

[Jose Manuel Cantera]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #15)
> Sorry, I copy/pasted the wrong URL in comment 11. It *was* uplifted on the
> 22nd, though.
> v2.1:
> https://github.com/mozilla-b2g/gaia/commit/
> 9b039a1bd37950e64ad827bb3b4208e367ed4464
> 
> Which I guess means it's back to you, Jose, to debug what's wrong.

Yes, you are right. I have reopened bug 1081748 to fix this problem. thanks Ryan

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Calling this bug "fixed" for v2.1 tracking purposes. Follow-up work is happening in bug 1081748.

Comment 18

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: The only deleted comment box disappears. All remaining comment boxes stay on the screen.

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141024001204
Gaia: 0f76e0baac733cca56d0140e954c5f446ebc061f
Gecko: 7d78ff7d25b6
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0