1068127 - Search activity providers missing or are not pathed correctly for different locales

Status: RESOLVED DUPLICATE of bug 1065306

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Aaron Train [:aaronmt]]

Switched device from en-US to de-DE

D/GeckoLocales(20704): System locale changed from en_US to de_DE

Opened the search activity, typed 'Firefox', and hit search

  D/GeckoJarReader(20704): No Entry for chrome/de-DE/locale/de-DE/browser/searchplugins/yahoo.xml

  D/GeckoJarReader(20704): No Entry for chrome/de/locale/de/browser/searchplugins/yahoo.xml

Nothing happened, no search results at all.

--
Nightly (09/16)
Samsung Galaxy S5 (4.4.4)

Comment 1

[Aaron Train [:aaronmt]]

and from en-US to fr-FR

D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/list.txt
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/yahoo-france.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/google.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/wikipedia-fr.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/eBay-france.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/twitter.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/bing.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr/locale/fr/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr/locale/fr/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr/locale/fr/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr-FR/locale/fr-FR/browser/searchplugins/yahoo.xml
D/GeckoJarReader( 4321): No Entry for chrome/fr/locale/fr/browser/searchplugins/yahoo.xml

Comment 2

[:Margaret Leibovic]

Some of this seems expected, since we try to use the full language/region tag before attempting to use just the language, although it does look like we're doing more work than we should.

Also, once bug 1065306 is fixed, we should be trying to find a default that will be in the locale, rather than falling back to yahoo (which is currently hard-coded for all locales).

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to :Margaret Leibovic from comment #2)
> Some of this seems expected, since we try to use the full language/region
> tag before attempting to use just the language, although it does look like
> we're doing more work than we should.
> 
> Also, once bug 1065306 is fixed, we should be trying to find a default that
> will be in the locale, rather than falling back to yahoo (which is currently
> hard-coded for all locales).

I see this falling out from Bug 1065306.  For each Android locale, there will be a set of search providers, more or less guaranteed to be in good working order.

Comment 4

[Richard Newman [:rnewman]]

Especially if you're using Nightly, there will be Android locales that don't intersect with any locale that we ship, even ignoring the region tag.

We should always expect the possibility of failure here.

Comment 5

[Richard Newman [:rnewman]]

Is this a dupe of Bug 1067026?

Comment 6

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #5)
> Is this a dupe of Bug 1067026?

I think the main issues here will be solved by a combination of bug 1065306 and bug 1067026.

However, there is still the issue that once we find lists.txt in the right place, we'll still look for the individual plugins in the other places first. I don't know if it really matters to optimize this, since it's just for the settings page, but this is some unnecessary work.

Comment 7

[:Margaret Leibovic]

I'm just going to dupe this to bug 1065306. This will be resolved once we actually support localized defaults, which that bug addresses.